Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask pitch surface for high jump or pole vault #5387

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

arrival-spring
Copy link
Contributor

Prompted by https://community.openstreetmap.org/t/how-to-tag-a-high-jump-mattress/106241

Looking at https://taginfo.openstreetmap.org/keys/athletics#values I think the rest make sense to ask for surfaces if such pitches exist.

I just made the change through the browser, so untested.

Copy link
Member

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though I have not run the code

@matkoniecz
Copy link
Member

@arrival-spring Have you run the code to confirm it works?

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Nov 25, 2023

I just made the change through the browser, so untested.

You can start a build in github gui in your branch and download an apk for test on a device.

@westnordost westnordost merged commit a1d2285 into streetcomplete:master Nov 26, 2023
@arrival-spring arrival-spring deleted the patch-3 branch November 26, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants