Fix element highlighting in amenity_coverage

[qugebert]

In the AddAmenityCover-Task,

it is asked for coverage of various amenitys (picnic_table,bbq, maybe more in the future), but the getHighlightedElements(..) was still hardcoded to highlight picnic_tables, but should highlight elements of the same type than surveyed to avoid misunderstandings, which element should be checked.

This was mostly copy&paste from the logik used in the CheckExistence-quest.

[westnordost]

That's true, it is an issue and thank you very much for the fix!

[westnordost]

Hmm, you made some extra changes that weren't in the title. Why not simply also highlight bbqs? I am not a fan of introducing complexity where it is not needed.

[qugebert]

Hmm, you made some extra changes that weren't in the title. Why not simply also highlight bbqs? I am not a fan of introducing complexity where it is not needed.

I'm not sure, if i understand this right.
I thought, this would be the easiest way, as this was already implemented.
And if someone adds other types of amenities in the future, the highlighting doesn't need to be changed again as it always searches for the neighbour of the same type.
How should i do this instead? Sorry, i'm really new to kotlyn/android programming so thank you for any suggestins how i can do this better.

[westnordost]

I guess you are right. In the future, the interface could be changed to be more straightforward to have less code in the individual quests, e.g.

class MyQuest(private val getFeature: (tags: Map<String, String>) -> Feature?) { ... }