Overlay button #5109
Merged
Overlay button #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - remove overlay selection from main menu - change location of "stop recording" button to left of gps button - reduce depth of layout hierarchy in main view
|
The icon in the new overlay button is not visible when using the dark theme. |
|
Fixed, thanks |
(the animations are like 90% of the work...)
Overlay tutorial
|
👏Thanks! When's that feature gonna be pushed to the play store? |
|
On the next release. I've moved to a slower release cycle, about once a month or less except there is something urgent, i.e. critical bugfixes. (I've actually received complaints that the app updates too often ^^.) Anyway, it's been a month now, so a new release is due soon. There is not that much new stuff apart from the overlay button & tutorial in it, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overlay button to map view. Fixes #5024
Also:
overlay.mp4
The button is at the top and I moved the "stop recording" button to the left of the gps button so that no UI elements overlap on screens with only 360dp width - in landscape mode.
320dp used to be standard up until iPhone 5 (2012), I don't think any phones exist nowadays with this screen width.
360dp is still somewhat the standard, though many phones are often wider (384dp, 480dp, ...)