Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#386 changing to singleTop lanunch mode for SettingsActivity #396

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

krzyk
Copy link
Contributor

@krzyk krzyk commented Jul 12, 2017

Changed launch mode from singleTop to singleTask for SettingsActivity.

@westnordost
Copy link
Member

I read through that document too now. It sounds to me as if it is a problem with Firefox launching the settings activity in the wrong launch mode. But anyway, if singleTask solves this, it is just as fine. Thank you for engaging yourself in it.

Did you test this fix at least with?:

  • Chrome
  • Stock browser (Android AOSP browser)
  • Firefox

@krzyk
Copy link
Contributor Author

krzyk commented Jul 12, 2017

Tested with Chrome and Firefox (and Yandex browser), currently I don't have a way to test with stock browser.
Maybe @Binnette has time to check if this fixes the behavior with stock browser?
If not the I'll try to debug why my android emulator doesn't start.

@westnordost
Copy link
Member

Okay I guess the stock browser doesn't seem to be around anymore.

@westnordost westnordost merged commit fdcc320 into streetcomplete:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants