-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handlebar holder answer in bike parking quest #3724
Conversation
This adds a new answer to the bicycle parking type quest, for "handlebar holder" type bicycle parking.
This bicycle parking type is really really rare. But it is a distinct value that appears to be well defined and it bothered you enough to create PR. And it may help to avoid mistakes by other people. So I would be support merging it. https://taginfo.openstreetmap.org/tags/bicycle_parking=handlebar_holder#overview https://taginfo.openstreetmap.org/keys/bicycle_parking#values |
In Switzerland it's really common (~70% of the total are mapped here) and I've also seen it elsewhere, so I think it's useful. |
Was discussed in #3061 Went from 214 in July 2021 to 401 today. Still really low - but no longer so absurdly low - and shows that many were actually not mapped (and presumably many still remain unmapped). |
Hmm I didn't realise they were so uncommon, I guess they're mostly just a Swiss thing. Still it would be very useful for me mapping them around here. |
The issue is - can we find a a clear line which bicycle parking types to include and which not? Why is such a line necessary? Not only to not overwhelm users with choices. Most of all because This is an issue for the same reason why adding documentation for e.g. Hence, if we want any sort of stability in bicycle parking type tagging, we need to classify it by their function, not their visual appearance, i.e. have some (implicit) categorization like we also have with |
I would argue that there's a couple of reasons for these to be defined separately from stands & wall loops:
|
When it is a separate type not redefining existing ones. For example it would exclude |
Alright, let's add it then |
Great thanks, is there anything else I need to do before it can be merged? |
No. It contains new strings, this is why it will be going into the next major release for which there is no branch yet. I will merge it when there is. |
This adds a new answer to the bicycle parking type quest, for "handlebar holder" type bicycle parking. These are quite common around me so this option will be useful at least to me. I just used the image used on the osm wiki page, but I could go out and take another photo that might work better in the tiny box at some point.