Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask about barrier on intersection of barrier line and path [ready for review, again] #3515

Merged
merged 45 commits into from
Jan 18, 2022
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
c461e74
ask about barrier on intersection of barrier line and path
matkoniecz Nov 18, 2021
476cd02
exclude also bridges
matkoniecz Nov 18, 2021
4310d51
remove inheritance, share code in other way, reorder properties
matkoniecz Nov 22, 2021
e76fbd0
import barriers in bulk
matkoniecz Nov 24, 2021
34fd289
barrier also on roads, drop inheritance where not needed
matkoniecz Nov 24, 2021
399cf5f
add separate icon for path and road
matkoniecz Nov 29, 2021
24b702a
Merge branch 'master' into intersection
matkoniecz Nov 29, 2021
74aed92
Merge branch 'master' into intersection
matkoniecz Nov 29, 2021
feb29e8
Merge branch 'master' into intersection
matkoniecz Nov 29, 2021
333094b
Update app/src/main/java/de/westnordost/streetcomplete/quests/barrier…
westnordost Dec 17, 2021
db6499e
Update app/src/main/java/de/westnordost/streetcomplete/quests/barrier…
westnordost Dec 17, 2021
f25c672
Update app/src/main/res/values/strings.xml
westnordost Dec 17, 2021
0ed9880
Merge branch 'master' into intersection
matkoniecz Dec 17, 2021
e97bfd0
extract shared code
matkoniecz Dec 18, 2021
adbed0c
painfully imperative rewrite
matkoniecz Jan 11, 2022
41464ed
try more functional
matkoniecz Jan 11, 2022
64f7344
extract to a separate file
matkoniecz Jan 11, 2022
12cfd72
apply new shared code to crossings
matkoniecz Jan 11, 2022
9224774
add more tests
matkoniecz Jan 11, 2022
a5eb81f
add test detecting regression that was introduced
matkoniecz Jan 12, 2022
e3c1c8e
add mirror test, fix typo
matkoniecz Jan 12, 2022
4e74395
skip tagged results, fix regression
matkoniecz Jan 12, 2022
cfeec8c
Merge branch 'master' into intersection
matkoniecz Jan 13, 2022
aee108e
reformat code
matkoniecz Jan 13, 2022
af3b03d
drop dead replaced code
matkoniecz Jan 13, 2022
cf6dc23
restore comments lost on merging
matkoniecz Jan 13, 2022
a09233b
tweak test description
matkoniecz Jan 14, 2022
089549b
fix leftover from merge conflict
matkoniecz Jan 14, 2022
c972d93
tweak whitespace
matkoniecz Jan 14, 2022
24d2370
Update app/src/main/java/de/westnordost/streetcomplete/quests/barrier…
matkoniecz Jan 14, 2022
57894bd
fix English
matkoniecz Jan 14, 2022
f7f682f
Update app/src/main/java/de/westnordost/streetcomplete/quests/barrier…
matkoniecz Jan 14, 2022
955fdb9
finish tweaking comment
matkoniecz Jan 14, 2022
46e3f56
remove dead code leftover
matkoniecz Jan 14, 2022
7063789
unify placement of @Test
matkoniecz Jan 14, 2022
8e59443
Fix terminology
matkoniecz Jan 14, 2022
d590448
Better phrasing of the commit message
matkoniecz Jan 14, 2022
c6fcd93
reformat complex if
matkoniecz Jan 14, 2022
073d97a
reformat complex condition
matkoniecz Jan 14, 2022
bd8d9b6
remove invisible rectangle that was used for SVG construction
matkoniecz Jan 14, 2022
ca43d8a
svg reduction with svgo
matkoniecz Jan 14, 2022
3713ca7
better formatting
matkoniecz Jan 14, 2022
4b805be
Fix crash on barrier=yes
matkoniecz Jan 14, 2022
9e630fb
More readable, shorter and maybe even more performant code.
matkoniecz Jan 16, 2022
59048ec
Merge branch 'master' into intersection
matkoniecz Jan 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update app/src/main/java/de/westnordost/streetcomplete/quests/barrier…
…_type/AddBarrierOnPath.kt
  • Loading branch information
westnordost authored Dec 17, 2021
commit db6499ede1c07ca8eaccc6da35c53c33ee65836e
Original file line number Diff line number Diff line change
@@ -31,11 +31,8 @@ class AddBarrierOnPath: OsmElementQuestType<BarrierType> {
}

override val commitMessage = "Add what is on intersection of path and barrier"
matkoniecz marked this conversation as resolved.
Show resolved Hide resolved

override val wikiLink = "Key:barrier"

override val icon = R.drawable.ic_quest_barrier_on_path

override val questTypeAchievements = listOf(PEDESTRIAN, WHEELCHAIR, OUTDOORS)

override fun getTitle(tags: Map<String, String>) = R.string.quest_barrier_path_intersection