Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add halal quest #3331

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Add halal quest #3331

merged 5 commits into from
Oct 1, 2021

Conversation

SMUsamaShah
Copy link
Contributor

@SMUsamaShah SMUsamaShah commented Sep 28, 2021 •
edited
Loading

Added halal quest. I just followed the trail of Kosher quest.
fixes #2990

@SMUsamaShah SMUsamaShah mentioned this pull request Sep 28, 2021
Closed
westnordost
westnordost reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few small comments / questions

app/src/main/java/de/westnordost/streetcomplete/quests/diet_type/AddHalal.kt Show resolved Hide resolved
app/src/main/res/values-en/strings.xml Show resolved Hide resolved
res/graphics/quest icons/halal.svg Outdated Show resolved Hide resolved
@FloEdelmann
Copy link
Member

FloEdelmann commented Sep 28, 2021 •
edited
Loading

@SMUsamaShah Please include fixes #2990 or closes #2990 in the pull request description, then it will be linked to the issue and close it automatically when the PR is merged. See also https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword.

peternewman
peternewman suggested changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you've edited the correct strings.xml!

app/src/main/res/values-en/strings.xml Show resolved Hide resolved
@matkoniecz
Copy link
Member

@SMUsamaShah Congratulations on your first accepted quest!

@SMUsamaShah
Copy link
Contributor Author

SMUsamaShah commented Sep 30, 2021 •
edited
Loading

@matkoniecz Yayy! and Thanks
closes #2990

@westnordost westnordost merged commit 3a9bd8a into streetcomplete:master Oct 1, 2021
@westnordost westnordost added hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event and removed hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternewman peternewman peternewman requested changes

@matkoniecz matkoniecz matkoniecz left review comments

@FloEdelmann FloEdelmann FloEdelmann left review comments

@westnordost westnordost westnordost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Does it offer Halal products" same as Kosher quest.
5 participants
@SMUsamaShah @FloEdelmann @matkoniecz @westnordost @peternewman