Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picnic table cover quest #3311

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Add picnic table cover quest #3311

merged 6 commits into from
Oct 1, 2021

Conversation

FloEdelmann
Copy link
Member

Closes #3142.

Screenshot

@westnordost
Copy link
Member

Also add it to the "outdoor" achievement?

(Maybe the achievement stuff should be refactored so that it is defined in the quests themselves to which achievements they should count. Contributors keep forgetting to add it)

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution!

Is the question wording the same as for the bus stop?

By the way, it is mostly just an OCD, but sometimes I also clean the SVG / XML with an editor, e.g. when I see that stroke properties are defined but a path has no stroke, or fill properties are defined but that path doesn't fill

Copy link
Member Author

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add it to the "outdoor" achievement?

Will do.

achievement stuff should be refactored so that it is defined in the quests themselves to which achievements they should count

Maybe I'll try to refactor this afterwards.

sometimes I also clean the SVG / XML with an editor

I'll clean them up manually.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@westnordost westnordost merged commit 84d36fd into streetcomplete:master Oct 1, 2021
@FloEdelmann FloEdelmann deleted the picnic-table branch October 2, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New quest: Is this picnic table covered?
2 participants