rework settings layout #1448
Merged
rework settings layout #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reworked setting layout based on what people actually want to change. My testing has a small sample size. But for now basically all people were interested in quest list - at least viewing it. Some also in changing. Some even started given unprompted advice to make it far more prominent. So it is moved higher while some settings much less likely/useful to change were downgraded into advanced settings. in UX testing multiple people that reached settings menu declared that quest selection should not be hidden in advanced settings I also shown quest list to some people after UX testing session and reactions where mix of - why I was not aware that X is disabled? I am very interested in this topic. - it is interesting - it is amazing - I really like icon X (often for the underground buldings) - I was not aware that there are some many question types - it should be displayed on first startup (I am pretty sure that it would have more negatives than positives). Also some people using SC declared that it should be less hidden. So it is promoted higher, out of advanced settings, visible without scrolling settings list. I also downgraded cache size into advanced, in normal operation there is no need to change it. I removed separate single element theme and cache group as unnecessary.
maybe it would be better to somehow disable them to not lose translations?
|
For visual changes, a screenshot in the PR description would be helpful though. 😄 |
I see no reason why a git commit message must be short. For documentation, it is a very good idea even. |
|
The changes make sense, thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked setting layout based on what people actually want to change. My testing has a small sample size. But for now basically all people were interested in quest list - at least viewing it. Some also in changing. Some even started given unprompted advice to make it far more prominent.
So it is moved higher while some settings much less likely/useful to change were downgraded into advanced settings.
in UX testing multiple people that reached settings menu declared that quest selection should not be hidden in advanced settings
I also shown quest list to some people after UX testing session and reactions where mix of
Also some people using SC declared that it should be less hidden.
So it is promoted higher, out of advanced settings, visible without scrolling settings list.
I also downgraded cache size into advanced, in normal operation there is no need to change it.
I removed separate single element theme and cache group as unnecessary.
Why I keep writing books in commit messages? Is full story behind such change is useful. And more useful than something like "reworked settings moving ones more likely to be used to the top, quest list was especially wanted according to the UX testing"? I somehow made XXL commit message again, I am planning to strongly avoid doing it with the next one, but maybe it is useful.
My work on this pull request and UX testing was sponsored by a NGI Zero Discovery grant