AddPlaygroundAccess [finished, ready for merging] #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENT8R
reviewed
Jul 13, 2018
| changes.add("access", "private"); | ||
| } | ||
| } | ||
| @Override public String getCommitMessage() { return "Add whatever playground is public"; } |
There was a problem hiding this comment.
Should not this be "Add whether playground is public"?
There was a problem hiding this comment.
I simplified the text here
westnordost
reviewed
Jul 14, 2018
app/src/main/res/values/strings.xml
Outdated
| @@ -609,5 +609,6 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
| <string name="quest_address_answer_no_housenumber_message2">Is this correct and is it not just part of a building?</string> | |||
|
|
|||
| <string name="notification_channel_download">"Download"</string> | |||
| <string name="quest_playground_access_title">Is this playground generally accessible?</string> | |||
matkoniecz
changed the title
|
The drawables are there now, btw |
matkoniecz
changed the title
matkoniecz
force-pushed
the
playground_access
branch
from
7728ace to
795cd49
Compare
matkoniecz
force-pushed
the
playground_access
branch
from
795cd49 to
c243fe8
Compare
matkoniecz
changed the title
|
Thanks for the icon! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1114