Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify vegetarian and vegan strings #883

Closed
huftis opened this issue Feb 20, 2018 · 7 comments
Closed

Clarify vegetarian and vegan strings #883

huftis opened this issue Feb 20, 2018 · 7 comments

Comments

@huftis
Copy link
Contributor

huftis commented Feb 20, 2018

The two strings clarifying what ‘vegetarian meals’ and ‘vegan meals’ are currently says:

Vegetarian meals contain no meat.
Vegan meals contain no animal products (no meat, no milk products, no eggs, …).

It’s a common misunderstanding, especially in some countries, that vegetarians eat fish (or even chicken!). So could this be changed to

Vegetarian meals contain no meat, fish, or poultry.
Vegan meals contain no animal products (no meat, fish, poultry, milk products, eggs, …).

?

I can create a PR if you approve this change.

@westnordost
Copy link
Member

Okay

huftis added a commit to huftis/StreetComplete that referenced this issue Feb 20, 2018
…e#883)

Clarifies that vegetarian and vegan meals don’t contain
fish or poultry. Also adds a non-breaking space in front
of the ‘…’ character in the list of things that vegan
meals don’t include, to avoid a line break there.
@huftis
Copy link
Contributor Author

huftis commented Feb 20, 2018

BTW, @westnordost, the comma before ‘or’ was not a typo. It was the serial comma, which most style guides for American English recommend: https://en.wikipedia.org/wiki/Serial_comma

Since the (de facto) default variant of English in free software is American English (with British English commonly provided as a ‘translation’), I used the serial comma. For British English, I would have omitted it.

(BTW, there are also a couple of other ‘britishisms’ and spelling inconsistencies in the strings.xml file.)

@rugk
Copy link
Contributor

rugk commented Feb 20, 2018

Yes, AFAIK these are mostly wanted, as OSM uses British English (also for tag names, etc). No 'Americanism' here… 😉

@rugk
Copy link
Contributor

rugk commented Feb 20, 2018

However, one may surely make a en_US translation at POEditor if that is possible. If not, open an issue, … 😄

@huftis
Copy link
Contributor Author

huftis commented Feb 20, 2018

@rugk I would guess that the default should be the Android default, which might differ from the OSM default. However, Android doesn’t seem to have a default language (https://developer.android.com/guide/topics/resources/multilingual-support.html).

But even with British English as the default for StreetComplete, there are still inconsistencies, e.g. ‘practised’ but ‘authorized’. (And the quotation marks for placeholders should be ‘ and ’, not “ and ”.) But all this it OT for this issue, so I‘ll add a separate issue (not tonight, probably tomorrow).

@westnordost
Copy link
Member

Ah, I did not know this.

Probably, it would be good to create an en_US strings.xml which overrides some of the strings in the default strings.xml and let the default strings.xml be British English all through. (Or the other way round, I don't really care). But anyway, that's a separate issue.

To go forward with this one, you could create a PR where you remove all the quotation marks from the quest titles. I will then contribute to that PR to implement to make it italic or something.

@westnordost
Copy link
Member

Oh, this is the vegetarian issue, nevermind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants