-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing religion tag to historic=wayside_shrine #799
Comments
Hmm, good idea, but the difference to #777 is extremely low. So I'd think this can be done in one quest. (It's basically just one more item to select and the denomination selection to hide.) |
It needs to be in separate quests reusing code as here denominations should not be selectable and both global and per country data will be different, as some religions are not making wayside shrines. |
Denomination should also not be selectable for other religious places. I already gave the reason for that. |
Are you sure? I looked through #777 again and I see no relevant comments. And at least for PoW I think that it makes sense to make selectable both only religion (christian) or exact denomination (Roman Catholic, orthodox, Greek Catholic, Polish Catholic) at least on some countries. |
Hmm, yes, I am pretty sure. Don't know where it ended up (email response), I can't find it neither.
|
At least in Poland any church will have this info posted on board/building plaque.
Ok, so I will make a separate one. |
I have a bit trouble with question here. Current best idea is awful
Note that a) shrines commonly have no names b) historic=wayside_shrine is also for places not used fr religious practices (and ones also tagged as place_of_worship are anyway covered by #777) |
code waits at at https://github.com/matkoniecz/Zazolc/commits/wayside_shrine for handling of #777 as it relies on some code changes introduced by this PR. Once #777 is processed I will make a PR, but I would appreciate feedback. Country-specific data is directly from OSM, if somebody is aware about some statistics which religion have wayside shrines in specific countries it may be useful. |
I know from my travels, that Buddhist and Hindu wayside shrines exist. No idea about the rest. |
From what I know Islamic shrines are not existing or highly unusual. I was unsure whatever it should be available as an option but in the end I kept it - maybe it should be removed. |
General
Affected key(s) (or tags) to be modified: religion
Question asked: What is the religion on XY?
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
reuse #777
Element selection:
Reuse #777
Metadata needed:
yes it is necessary and I may supply it (for areas that are already mapped in OSM)
Proposed GUI:
Reuse #777, but without allowing to supply info about denomination (as it is extremely tricky to get this right for some shrines)
Promises:
I plan of making quest like this, if idea of quest is accepted I plan on making it good enough for StreetComplete PR.
The text was updated successfully, but these errors were encountered: