Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gate creating note for cycleway quest behind "select 'no' answer for both sides if no bicycle infrastructure is present" #768

Closed
matkoniecz opened this issue Jan 14, 2018 · 14 comments
Assignees

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Jan 14, 2018

Multiple people created notes in bikeway quest rather than selecting "no" for both sides.

Maybe it would be a good idea to have "note, you can select that there is no bicycle infrastructure by selecting "no" for both sides" dialog before allowing user to create a note? Similar to how one gets warning before selecting "no name" for street name quest?

Some recently encountered examples:

https://www.openstreetmap.org/note/1267398

https://www.openstreetmap.org/note/1262510

https://www.openstreetmap.org/note/1245283 (probably)

https://www.openstreetmap.org/note/1250200

Most of notes from this quest that I was able to understand are of this type (see https://ent8r.github.io/NotesReview/expert/?query=StreetComplete&limit=3000&start=true ).

@matkoniecz matkoniecz changed the title add info that adding cycleway:both=no is not requiring creating a note gate creating note for cycleway quest behind "select "no" answer for both sides if no bicycle infrastructure is present" Jan 14, 2018
@matkoniecz matkoniecz changed the title gate creating note for cycleway quest behind "select "no" answer for both sides if no bicycle infrastructure is present" gate creating note for cycleway quest behind "select 'no' answer for both sides if no bicycle infrastructure is present" Jan 14, 2018
@smichel17
Copy link
Member

smichel17 commented Jan 14, 2018

At least in English, I think the problem is a phrasing mismatch between the question (Is there a cycleway in this street?) and answers [Okay | Can't Say].

I think it would make more sense to use the following structure:

Is there a cycleway in this street? [Yes | No | Can't Say]

Yes -> Open the current dialog to select the type of cycleway: "What kind of cycleway does this street have? <picker> [Okay | Cancel]"

No -> Same as if I had selected no cycleway on both sides of the street and pressed okay.

Can't say -> Same as current.


This would also make it significantly faster to mark no cycleway, which would be really nice in places like the US where they are not (yet) very common and so I'm hitting "None" a lot.

@westnordost
Copy link
Member

@smichel17 The current dialog is a little bit more complex. I.e. you have to select both sides. To have all this UI in just a dialog seems too volatile to me. Also, that "dialog" would then open another dialog on top of it to allow for cycleway type selection. This kind dialog-stacking is a form of UX I want to avoid where possible.

@westnordost
Copy link
Member

One could add an "other answer" option named "No bicycle infrastructure whatsoever" or alike perhaps.

@westnordost westnordost added enhancement feedback required more info is needed, issue will be likely closed if it is not provided labels Jan 14, 2018
@matkoniecz
Copy link
Member Author

"bicycle infrastructure not present"? It seems simpler.

@westnordost
Copy link
Member

"No bicycle infrastructure" even shorter :-)

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jan 14, 2018
@matkoniecz
Copy link
Member Author

Probably some people will be confused by bicycle infrastructure like parkings or bicycle rental stations but I have no idea how to avoid this issue.

@rugk
Copy link
Contributor

rugk commented Jan 14, 2018

"No way for bicycles" (just somehow avoid the term "infrastructure")

@matkoniecz
Copy link
Member Author

"No way for bicycles"

This may get confusing with shared lanes (bus + bicycles lane, contraflow without dedicated lane, bicycles allowed on footway...)

@smichel17
Copy link
Member

@westnordost The way I envision it working does not have the problems you brought up, I think. I will make a mockup to clarify.

@smichel17
Copy link
Member

smichel17 commented Jan 14, 2018

cycleway

Honestly the "What kind of cycleway" part could probably be removed.

Pressing "Back" (which could be named "Cancel" as easily) would have the center part slide back down and return to the first state.

@westnordost
Copy link
Member

Ah! Well, this is interesting. Hmm... but it would not be that simple to implement.

@smichel17
Copy link
Member

Don't we already have a slide-up animation? In that case the center part should just be a matter of having a hidden view. The hard part, I think, would be changing the bottom labels without opening a new dialog, as I assume that's currently handled by android.

@westnordost
Copy link
Member

Hm, not at all simple. I think I prefer the "other answer" option, looking at the effort to tear that all up and refactor to enable this.

Also, I said that earlier, I think: I do not want to make it (much) easier to answer "no, no cycleway" than specifying the cycleway. Otherwise, it may encourage users to sweep through whole areas of towns without even doing a survey.
See for example here: https://www.reddit.com/r/Android/comments/6dqdl6/streetcomplete_the_easiest_way_to_contribute_to/di5l5ba/

@westnordost
Copy link
Member

westnordost commented Jan 24, 2018

I decided to, after all, not implement this, but instead only change the wording of the question slightly: "Is there a cycleway here? What type?" so that the answer format ("OK" instead of "Yes/No") is not at odds with the question.

The "No bicycle infrastructure" answer could lead to wrong taggings in the case where instead of "no cycleway", "cycles go implicitly/explicitly on sidewalk" should be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants