Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible rendering of quest markers for linear features #733

Closed
althio opened this issue Dec 21, 2017 · 11 comments
Closed

More flexible rendering of quest markers for linear features #733

althio opened this issue Dec 21, 2017 · 11 comments
Assignees
Milestone

Comments

@althio
Copy link
Contributor

althio commented Dec 21, 2017

This is about markers for quests related to linear features, typically roads surface, street names, ...

Roads segments can be quite long and it looks like the marker is located at a fixed position on the middle-point/centroid of the linear features.
I think that at the typical zoom used in the app, you can easily walk on a street or cross a street but miss a marker. This is because the marker quest is out of the screen.

Suggestions:

  • add several markers, regularly spaced on the line (space may be zoom-dependant)
  • see if the marker position can be floating, anywhere on the line, to dynamically choose the position on the line, within the screen, without colliding too much with others markers/labels.
@westnordost
Copy link
Member

westnordost commented Dec 21, 2017 via email

@esilja
Copy link
Contributor

esilja commented Dec 21, 2017

Could you expand why the second suggestion is technically impossible?

@althio
Copy link
Contributor Author

althio commented Dec 21, 2017

add several markers, regularly spaced on the line (space may be zoom-dependant)

regarding your first suggestion: It would be possible but I don't really like it. People would get confused because it looks as if there were several quests when there is only one.

Is it possible to choose the spacing so that marker could appear only once on screen? (but at least marker position is not tied to centroid only)

Note that most linear quests require you to walk down the whole of the road, so theoretically, one can not miss it.

That is not my experience.
A street name is more easily found at the beginning or the end, not at the centroid, and I don't think you are required to walk down the whole street.
Also if you are walking with GPS on, at high-zoom, you can cross streets/roads and never know they have quests to begin with. Kind of defeat the purpose of walking them down.

@westnordost
Copy link
Member

westnordost commented Dec 22, 2017 via email

@westnordost
Copy link
Member

westnordost commented Dec 22, 2017 via email

@althio
Copy link
Contributor Author

althio commented Dec 22, 2017

Thank you for the technical answers. (I hope you still enjoy your travel!)
I will try some other replies and suggestions, let's see if they are useful.

But you are still required to check if the whole stretch indicated has the same name. Street names may change at intersections.

"required to check if the whole stretch": I don't think that one ponctual marker (the centroid or any other point) is suitable to express this. Anyway I think that is clear enough when you click on the marker: app zooms out, show&highlight the whole feature. This is not an argument for centroid position versus other postion in my opinion.

On the other hand, I think the discoverability of the marker and the quest is not very good. If you don't see it, you cannot click on it.
I would rather have markers at near-beginning and near-end of the line than centroid for quest like street names and speed limit. That is the natural place for street signs and speed signs.
Right now:
If you are at the centroid, you have the question but not the answer.
If you are at the extremity, you have the answer but not the question.
Distance between centroid and extremity can be large enough (pan several times screen size or zoom out a lot)

People would get confused because it looks as if there were several quests when there is only one.

Really?
Even if the related markers and line are all shown & highlighted together on click?
And of course all removed together if quest is done or hidden?

There is another ticket somewhere with a feature request somewhere in which the closest quest should be shown at the border of the screen and I plan to implement it as soon as it becomes technically possible.

This is #642 (comment) or #142 (comment) but this is only intented if no quest at all are shown.
It might mitigate the issue but will not resolve it in dense urban area where a lot of other quests (opening hours, ...) might appear between the extremity and the centroid of the street and block the discoverability of the quest related to the whole street.

@westnordost
Copy link
Member

westnordost commented Dec 22, 2017 via email

@westnordost
Copy link
Member

I recently tried out StreetComplete in Prachuap Khiri Khan and I understand now that this feature can make sense. (But not for all linear quests.)

@westnordost westnordost self-assigned this Nov 19, 2018
@westnordost westnordost added this to the v9 milestone Dec 2, 2018
@westnordost
Copy link
Member

Alright, implementation is almost done. I implemented it this way that the quest markers appear 15m away from the end of the element so that they are not all directly at the intersection. (So if the way is shorter than 4*15m, the quest marker is shown in the center as before)

The question is for which quests the markers should show at the ends. Definitely for oneway, maxspeed, road name and road construction because they all require to look for a sign at the entrance/exit of the road.

Currently I am thinking that the other way-based quests where the task is not to read a sign at the start/end of the road but to check something for the whole way (cycleway, cycleway segregation, surface, track type and way lit) should continue to show the quest marker in the center.

westnordost added a commit that referenced this issue Dec 2, 2018
@rugk
Copy link
Contributor

rugk commented Dec 2, 2018

The question is for which quests the markers should show at the ends

At both ends?

If yes: I suppose it looks quite weird if you have a way, where you can see both ends and it looks as if you have a quest twice, or, if you solve it, you may wonder why another one disappears.
If not: I'd say if both ends of the street are visible, show the quest in the middle of the street, as before.

(or some kind of "floating" as it has been proposed before)

@westnordost
Copy link
Member

Yes, at both ends. I think it will not be confusing because when you zoom into the quest, you clearly see that there is a quest marker for the same quest at both ends.

If not: I'd say if both ends of the street are visible, show the quest in the middle of the street, as before.

This is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants