Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and correct inconsistent surface attributes #662

Closed
cyclingcat opened this issue Oct 25, 2017 · 5 comments · Fixed by #4105
Closed

Check and correct inconsistent surface attributes #662

cyclingcat opened this issue Oct 25, 2017 · 5 comments · Fixed by #4105
Labels
feedback required more info is needed, issue will be likely closed if it is not provided new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@cyclingcat
Copy link

The OSM tags "surface" and "tracktype" are often used together in order to describe a way tagged as "highway=track". However, sometimes the attributes are inconsistent with each other, e.g. "surface=asphalt, tracktype=grade2" or "surface=gravel, tracktype=grade1". Many maps (e.g. OsmAnd and OpenMTBMap/Velomap for Garmin devices) render paved ways differently which is very useful for road cyclists.

Ideas:

  • If a surface quest is solved, the app could examine, if "tracktype" is set. If it's not, set it accordingly. If this attribute is already set, check if it's correct and in case it's not, correct it (maybe show a warning?)

  • Discover these kinds of discrepancies and show them as normal "surface" quest as if the attributes aren't already set. If the quest has been solved by a user, proceed as stated above.

The cycling cat

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Oct 25, 2017
@westnordost
Copy link
Member

westnordost commented Oct 25, 2017

To be designed more specifically. Not sure if this quest can be made:

Take into account, that a "these attributes are inconsistent"-detection must be in always correct. Since SC is not a QA tool where you can in doubt opt to mark something as false-positive, this option does not exist for this app. To cite the quest suggestion guidelines:

🤔 No unanswerable quests: All generated quests need to be actually answerable (no false-positives). This means that any answer given by the user must result in something being tagged. [...]

For example, the case that this app detects a (possible) inconsistency and asks the user of this app which surface this road really has, and the user answers exactly the same surface as was tagged before (or tracktype respectively), may never happen. Can you guarantee that?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 25, 2017
@matkoniecz
Copy link
Member

surface=asphalt, tracktype=grade2

May be valid with overgrown or extremely deteriorated asphalt.

surface=gravel, tracktype=grade1

This one should be always incorrect and require either changing of surface (for example to compacted) or of tracktype.

@westnordost
Copy link
Member

So, any feedback, @cyclingcat ?

@cyclingcat
Copy link
Author

I tried to research if "surface=asphalt, tracktype=grade2" is indeed a valid combination. While the English wiki page is sometimes a little vague (it uses adverbs like "mostly" or "usually", thus allowing these kinds of combinations, at least for special cases), its German counterpart clearly distinguishes between "waterproof surface" (like tarmac, concrete, cobblestones) for tracktype=grade1 and "water-bound surface" (like gravel and other compacted materials) for tracktype=grade2, thus forbidding "surface=asphalt, tracktype=grade2". So maybe it isn't as clear as I originally assumed. The same goes for "surface=gravel, tracktype=grade1".

Perhaps it's indeed too ambiguous for SC...

The cycling cat

@westnordost
Copy link
Member

Ok then, but would be an idea for osmose!

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Jun 13, 2022
ask for confirmation in case where surface mismatches tracktype
resurvey in cases where either surface or tracktype is definitely wrong
fixes streetcomplete#662 streetcomplete#4063
mnalis pushed a commit to mnalis/StreetComplete that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants