Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asks for housenumber for building=hospital with name="Haus F" #624

Closed
versat opened this issue Oct 2, 2017 · 10 comments
Closed

Asks for housenumber for building=hospital with name="Haus F" #624

versat opened this issue Oct 2, 2017 · 10 comments
Assignees
Labels

Comments

@versat
Copy link

versat commented Oct 2, 2017

It is about this building:
https://www.openstreetmap.org/way/337269628
and this building:
https://www.openstreetmap.org/way/131908057

Despite these buildings have already names, StreetComplete keeps asking for a housenumber.
I can not see any housenumber and i think the buildings of this hospital are not numbered but have names (maybe this is common about hospitals, i do not know).
I think it is still ok for StreetComplete to ask for a housenumber when there is only a name.

But what i would say is a bug is the following:
If i click on "Weitere Antworten"/"Further Answers", there is the option "Keine Nummer aber ein Hausname"/"No number but a housename". This is the case, so i clicked on it. Then it lets me enter the housename. But i know that the building already has a name, so i do not want to enter a name again.
I'm not sure what i would expect to be the correct behaviour.
Maybe StreetComplete should not ask for housenumbers at hospital buildings that already have a name (Like it is the case with university buildings i guess).
Maybe StreetComplete should have another option when there is already a name to just tell it that the building has no housenumber and ignore this specific issue in the future.
But overwriting an existing name is not that good i would say.

Regards
versat

@rugk
Copy link
Contributor

rugk commented Oct 2, 2017

As per the Overpass query here it should already exclude buildings, which already have a addr:housename.

@versat
Copy link
Author

versat commented Oct 2, 2017

I see. And since the tag "name" is used in my examples and not "addr:housename", StreetComplete asks for a name.
I'm not sure which tagging is correct for my examples.
Should i add "addr:housename" or change "name" to "addr:housename"?
Should/Could StreetComplete give a hint when a "name" tag is already used and ask to copy it to "addr:housename" (or use "name" value as default for "addr:housename" value)?
These are just some thoughts, i do not know what would be correct.

@westnordost
Copy link
Member

westnordost commented Oct 2, 2017 via email

@westnordost
Copy link
Member

Actually, @versat , which version of Streetcomplete are you using? Since 2.0, the app does not ask for the housenumber for buildings within an area that already has a housenumber anymore.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 4, 2017
@versat
Copy link
Author

versat commented Oct 4, 2017 via email

@rugk
Copy link
Contributor

rugk commented Oct 4, 2017

Related: #626 (comment) ?

@westnordost
Copy link
Member

Once the quests are created on your device, they don't vanish if the behavior how they are created changed.

@versat
Copy link
Author

versat commented Oct 5, 2017

I have deleted the cache and data of the app. Now some issues that were missing are shown. But the wrong housenumber issues (examples) are still shown too. I guess i can not do more to get rid of obsolete issues.

@westnordost
Copy link
Member

I will investigate.

@westnordost westnordost added bug and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Oct 5, 2017
@westnordost westnordost self-assigned this Oct 5, 2017
@westnordost
Copy link
Member

Ok so the hospital area is not recognized as an area by the app, investigating why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants