Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "barrier permanently removed" to barrier quests #6015

Closed
HolgerJeromin opened this issue Nov 18, 2024 · 4 comments
Closed

Allow "barrier permanently removed" to barrier quests #6015

HolgerJeromin opened this issue Nov 18, 2024 · 4 comments

Comments

@HolgerJeromin
Copy link
Contributor

Use case

To make the city more bicycle friendly my city has removed some barriers and put some cover cap inside.
So it is possible to put in again a bollard.

Proposed Solution
Right now I have to retag it via vescpucci.
Would be nice if this would be easier (for the simple cases: node on way) via SC itself.
Placing an entry in "er..." menu would be an option:
Looking at Taginfo we could tag:

@mnalis
Copy link
Member

mnalis commented Nov 18, 2024

I've looked at e.g. "What type of barrier is this?" quest and it at least seems to have "Uh..." / "It does not exist" answer. If that not adequate to tag a barrier which was removed? Or is that answer misbehaving (e.g. breaking geometry by removing whole node?)

Or do you think that changing the tag to was:barrier=* is more useful than just removing barrier=* tag?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 18, 2024
@westnordost
Copy link
Member

westnordost commented Nov 18, 2024

Deleting the node is already enabled on

  • AddBicycleBarrierType
  • AddBarrierType
  • AddBicycleBarrierInstallation
  • AddStileType
  • AddTrafficCalmingType

It was missing for, I added it

  • AddStepCountStile

For

  • AddBarrierOnPath
  • AddBarrierOnRoad

we can't delete the node, because there are no tags on the node. It is the common node of a road with a barrier line. So, the barrier line would need to be removed if the barrier really is no more. But in StreetComplete, we cannot delete lines.

@matkoniecz
Copy link
Member

we can't delete the node, because there are no tags on the node. It is the common node of a road with a barrier line. So, the barrier line would need to be removed if the barrier really is no more. But in StreetComplete, we cannot delete lines.

and if there is no barrier then creating note is a good idea, it indicated a mapping error

the most common cause of this I have seen is putting barrier=fence on landuse=residential and then gluing landuse to roads

@riQQ riQQ added enhancement and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Nov 19, 2024
@HolgerJeromin
Copy link
Contributor Author

Sorry missed the point that I got this problem with the barrier_opening/AddBarrierOpening.kt quest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants