Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Actually, there is a sidewalk, but it is displayed separately on the map." - applied answer may be wrong, sidewalk may be only on one side #5952

Closed
matkoniecz opened this issue Oct 7, 2024 · 5 comments · Fixed by #5976
Labels

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Oct 7, 2024

quest_accessible_for_pedestrians_separate_sidewalk has

Actually, there is a sidewalk, but it is displayed separately on the map.

wording.

If selected

will apply sidewalk:both=separate

But sidewalk may be actually only on one side. Maybe adding sidewalk=separate would be better? Or just remove existing sidewalk* tags?

@matkoniecz matkoniecz changed the title "Actually, there is a sidewalk, but it is displayed separately on the map." - applied answer may be wrong "Actually, there is a sidewalk, but it is displayed separately on the map." - applied answer may be wrong, sidewalk may be only on one side Oct 7, 2024
@westnordost
Copy link
Member

sidewalk=separate is invalid tagging, as far as I know.

But yeah, the sidewalk tag could just be removed. The wording of the other answer would then also need to be changed to "Actually, there is a sidewalk". However, note that the sidewalk quest is disabled by default.

@matkoniecz
Copy link
Member Author

matkoniecz commented Oct 7, 2024

sidewalk=separate is invalid tagging, as far as I know.

AFAIK it is fine, and while :left :right :both may be preferred for extra detail (sidewalk=separate means that sidewalk is at one side, or both), this is also accepted and in use and understood

see https://taginfo.openstreetmap.org/tags/sidewalk=separate#overview

@westnordost
Copy link
Member

Right, then I remember it wrong. Care to make the change yourself?

@matkoniecz matkoniecz self-assigned this Oct 7, 2024
@riQQ riQQ added the bug label Oct 7, 2024
@westnordost
Copy link
Member

Actually, I like my proposal better. It also reduces unnecessary text length and gives the user the opportunity to specify it more precisely afterwards. (StreetComplete interprets sidewalk=separate as sidewalk:both=separate, and so do all other data consumers)

westnordost added a commit that referenced this issue Oct 20, 2024
@westnordost
Copy link
Member

I did that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants