-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask for all equipment at amenity=bicycle_repair_station
#5910
Comments
Needs good pictures or icons.
The recycling quest doesn't have this, though. In general, the quest should behave similar as the recycling materials quest for consistency. If any changes (in usability, behavior) are made for one, it should be made for the other, too. |
Agreed. I'm not sure if icons would cut it (beside
Or of course if people can take their own photos which could be used, and would be clear and recognizable on small screen, that would be great too!
(Generally I agree; recycling quest would benefit there too I think. But I don't think that I'd be able to complete such task in Kotlin 😿 ) |
I think the pump pictures are not good, not recognizable enough as a pump. Maybe there are better stand-pictures, or the text needs to be a bit longer to explain that you can affix your bike frame onto it while you work on it. |
https://commons.wikimedia.org/wiki/File:Station%C3%A4re_Fahrradpumpe.jpg looks fair, or otherwise the generic https://commons.wikimedia.org/wiki/File:Bike_pump.jpg would be fine, too. The first one is really good, actually, because of the perspective, it fits very well in a square thumbnail while showing everything that makes it recognizable as a pump at a good scale (the pressure gauge, the lever) The previous pump pictures were not good IMO because they were not well recognizable as a pump. |
(As asked in #5870 (comment) opening this as a new issues in correct template; also see there for previous discussions)
General
Affected tag(s) to be modified/added: service:bicycle:pump, service:bicycle:stand, service:bicycle:tools, service:bicycle:chain_tool
Question asked: What equipment is available on this bicycle repair station?
Quest description shown: If non-standard equipment not listed is available here, please leave a note instead. / Select all that apply:
Checklist
Checklist for quest suggestions (see guidelines):
chain_tool
requiring a closer look)Ideas for implementation
Element selection:
Metadata needed: -
Proposed UI: Multiselect quest in style of
What can be left here for recycling?
, with 4 pictures (in two rows) with text corresponding toPump
,Stand
,General tools
,Chain tool
.However, while selecting an option would mark equivalent tag as
yes
, deselecting (as opposed to recycling quest which just ignores them) would tag it asno
(to prevent quest being re-asked ad infinitum if not all equipment is present).On quest startup, quest answers should be pre-populated with existing data (e.g. if node is tagged only with
amenity=bicycle_repair_station
+service:bicycle:pump=yes
,Pump
answer should be pre-selected, and all others deselected).Also, preferably, if any
service:bicycle:*
tag was not present, quest should automatically be marked "dirty" (i.e. just like as if the answer has been modified by a user), as aborting quest is not the same as just clicking OK (OK will tag all non-selected answers as=no
, even if initially they were just missing); but that is not requirement, just an idea.(Also, once this quest is implemented, existing
quests/air_pump/AddBicyclePump.kt
could be modified to not ask for pumps onamenity=bicycle_repair_station
, as it would be redundant.)The text was updated successfully, but these errors were encountered: