Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quests don't show up until map is moved after download #5823

Closed
RubenKelevra opened this issue Aug 21, 2024 · 7 comments
Closed

Quests don't show up until map is moved after download #5823

RubenKelevra opened this issue Aug 21, 2024 · 7 comments

Comments

@RubenKelevra
Copy link
Contributor

I noticed that quests are not rendered after loading a new section, if the map is not moved. Looks like there might be missing some kind of refresh command.

Screenshot

InShot_20240821_145738541.mp4

How to Reproduce

  • Move map to a not yet loaded section.
  • Download section
  • See no quests rendered after download is completed

Expected Behavior
Quests pop up after download and processing is completed.

Versions affected
Android 12
SC 59.0 Alpha 1

@westnordost
Copy link
Member

Oh, that sounds familiar. Actually, a similar issue existed in tangram-es, but it was not visible on a normal device because the map rendering was updated due to the compass direction shown on the map being updated all the time.

But anyway, from the video it looks like you perhaps zoomed out too much for them to be visible in the first place? Is this reproducible if you are zoomed in more?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Aug 21, 2024
@RubenKelevra
Copy link
Contributor Author

But anyway, from the video it looks like you perhaps zoomed out too much for them to be visible in the first place? Is this reproducible if you are zoomed in more?

Yeah (note the already rendered quests on the left). This was captured right after the download was finished.

InShot_20240821_175229325.mp4

@westnordost
Copy link
Member

Okay, my suspicion is that this actually is deliberate impmlementation on our side and done for performance reasons. Quests will only pulled from the database when a certain maximum area / maximum number of tiles are in view. Once they have been pulled from the database however, they continue being displayed even on lower zoom levels.

@RubenKelevra
Copy link
Contributor Author

Ah yeah, that makes sense that it doesn't happen if you're zoomed in further.

However the justification doesn't make much sense for this usecase: If you download a larger area you expect the app to lag for a second - maybe - while processing. So I think it would be fine to force loading them from the database once on manual downloads - if possible.

The reason being is that if you download an area manually you going to be zoomed out as much as possible - if you wanna preload the area.

Not showing the new quests in this case is weird and might be confusing for users.

@westnordost
Copy link
Member

westnordost commented Aug 22, 2024

I can confirm that data is definitely showing up immediately and thus it has something to do with being zoomed out that much.

So, it's not a bug.

@westnordost westnordost removed bug feedback required more info is needed, issue will be likely closed if it is not provided labels Aug 22, 2024
@Helium314
Copy link
Collaborator

Maybe you could increase the 16 tile limit in quest pins manager? I set it to 32 in SCEE, and didn't have noticeable performance issues on S4 Mini.

@westnordost
Copy link
Member

Ok, if Mr. Performance says that it's no problem, let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants