Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tourism=camp_site: power_supply asks wrong question #5776

Closed
vsessink opened this issue Aug 1, 2024 · 18 comments · Fixed by #5796
Closed

tourism=camp_site: power_supply asks wrong question #5776

vsessink opened this issue Aug 1, 2024 · 18 comments · Fixed by #5796
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@vsessink
Copy link

vsessink commented Aug 1, 2024

How to Reproduce
Find a tourism=camp_site or tourism=caravan_site. Wait for the question quest_camp_power_supply_title

The question says: "Is there any way for customers to charge their phone, laptop etc. here?" It then changes the power_supply tag.

This is wrong. The power_supply tag has nothing to do with phones or laptops.

The OSM tag "power_supply" just means that there is electricity "available" on the camp site: power_supply=yes - means, there is a power supply available (e.g. on a camp_site)

The tag seems to imply that this means power supplies at the pitches, because a blue 3-pin socket is being described - which is the typical (European?) outdoor power supply for camp sites. (power_supply cee_17_blue Blue 3-pin socket with 230V is available is what the example says but that is deprecated, power_supply=yes and socket=cee_17_blue would be the preferred way to encode a blue 3-pin socket).

Expected Behavior
Question should conform to the tag it is asking about, in this case: power_supply. As the camp_site OSM tag says that power_supply means "There is power supply available for customers", better wording would be: "is there electricity available for customers to use".

This still is ambiguous, but more aligned to the OSM tag it changes.

"Is there electricity available on the pitches" or "are there power sockets available on the pitches" is probably the original meaning of the power_socket tag.

External links
https://wiki.openstreetmap.org/wiki/Proposal:Extend_camp_site camp_site extension proposals (with power_supply examples)
https://wiki.openstreetmap.org/wiki/Key:power_supply original power_supply tag
https://wiki.openstreetmap.org/wiki/Key:socket:* list of socket types

Versions affected
v58.w

@vsessink vsessink added the bug label Aug 1, 2024
@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Aug 1, 2024
@matkoniecz
Copy link
Member

power_supply tag has nothing to do with phones or laptops.

this is quite overstating things, as both are typically powered by electricity provided by power sockets

In which cases this question will result in wrong answers?

@matkoniecz
Copy link
Member

maybe exact text was discussed at #4213

@vsessink
Copy link
Author

vsessink commented Aug 1, 2024

Well, I'm actually at a camping place now. All pitches have a cee_blue socket, but my answer to "Is there any way for customers to charge their phone, laptop etc. here" would definately have been "no", as there are no ways to charge anything here.

The only reason I answered "yes" was because I questioned the wording and took a search to see what the answer would do - which ended up being power_supply=yes/no.

Making the question specific (about "charging" and "phones") makes it confusing. A question should be as generic as possible. Making a question specific implies that the answer is specific, i.e. you don't ask "can you buy croissants here" if you just mean "is this a bakery" - and you don't ask "can you charge your phone here" if you mean "is there electricity for the customers".

The problem that power_supply seems to imply that it's on the pitches - but that that's not mentioned in the definition is then left as an excercise to the dev team ;-)

@matkoniecz
Copy link
Member

took a search to see what the answer would do - which ended up being power_supply=yes/no.

BTW, exact tags are also shown in undo view (you can enable flight mode, do edit, undo edit and it will not even appear in database)

@matkoniecz
Copy link
Member

@mnalis maybe you remember it being discussed one way or another?

@vsessink
Copy link
Author

vsessink commented Aug 1, 2024

@matkoniecz here #4198 (comment) and the reason for the specific question seems that @mnalis tries to ask for the minimum (i.e. "is there any sort of power available to customers, at least to charge your phone"). But that, again, is not what is asked.

The issue that the power_supply tag itself is defined ambiguously in osm (acknowledged by @mnalis in #4198 (comment)) remains.

@westnordost
Copy link
Member

westnordost commented Aug 2, 2024

So, I understand that this ambiguity could be solved by refining the wording? Does someone have a suggestion for a concise and unambiguous wording? The question should not be too long or complicated, otherwise people might skip on reading it.

There is also the possibility to add an explanatory text behind an "info" button displayed to the right of the question (see contributing a new quest). However, it should only be used to explain doubts about (terms used in) the question itself, not mandate how the question should be answered, because people will only click that info button in the first place if they do have doubts and otherwise don't read it.

In any case, the quest is @mnalis work, so I'd like to leave dealing with enhancement suggestions to him. Let's see what he thinks about it.

@mnalis
Copy link
Member

mnalis commented Aug 2, 2024

yes, it is not perfect, but seems to me the least confusing one. IIRC there was some back and forth both in the issue and the PR, and this was the one settled on.

The idea indeed was to provide whether there is power supply available for EVERYONE (and not just for caravans/RVs owners, which would likely often be misanswered as "no" by most of them if the question was generic "is there electricity for the customers?" if the cee_17_blue socket was missing, but e.g. schuko was present at shared space)

"is there any sort of power available to customers, at least to charge your phone"

might seem better - at least if one includes laptops specifically too, as sometimes usb-a might be provided (e.g. via solar-powered bench) but no regular domestic power connector like schuko, which again severly limits its usability for general use case (just like cee-17-blue does) -- but there are reasonable length limitations to observe too.

Nowdays quests IIUC allow to split the qestion into question+description, so perhaps it could be somewhat improved. Feel free to suggest how it might be improved in that way (I'll try to participate, but for next two weeks I might be quite limited in that)

Additional problem for clarifications is that specific sockets available might vary by region,so that should be taken into consideration too.

@vsessink
Copy link
Author

vsessink commented Aug 2, 2024

I'll send a patch with proposal when I'm home (currently still on a camping with eec_blue sockets, which started this all ;-)

@mcliquid
Copy link
Contributor

mcliquid commented Aug 2, 2024

I don't know if the reference to the phone is our best option is here. Can't the question be more generalized? What should the components be?

  1. it is about electricity
  2. this current should be usable (not locked or switched off and also not have a completely unusable voltage)
  3. it is not about what the electricity should be used for
  4. it doesn't matter which plug it is
  5. its only available on a camp site
  6. and there only for the guests

How about a general question: Is a usable power supply available here?

Alternatives

Are there designated power sockets for guests to this campsite?

  • Tried to clarifiy whether there are official power outlets accessible to guests, minimizing the risk of marking private or unofficial sources as available and it should be clear and specific.

Are there designated areas with power sockets for tents or caravans at this campsite?

  • This one specifically refers to designated areas, limiting the data collection to areas actually intended for power connections.
    It prevents misinterpretations by emphasizing the need for clearly designated areas. On many campsites, the power supply is only included/available on "premium" pitches, not on the cheaper basic pitches.

@mnalis
Copy link
Member

mnalis commented Aug 2, 2024

"Is a usable power supply available here?" and "Are there designated power sockets for guests to this campsite?" fail to clearly indicate "for who" - e.g. RV owner would likely answer exclusively on existence of cee-17-blue sockets (in most of EU), which is not what we want. (see previous explanation)

"Are there designated areas with power sockets for tents or caravans at this campsite?" is better in that regard (although IMHO still not as explicit why we ask what we do), but it also introduces other confusions (e.g. in all smaller camps and most of the big ones IME there wouldn't be designated power sockets for tents, but they would exist in e.g. provided outdoor kitchen or covered "shared/mingle space" or elsewhere )

@mcliquid
Copy link
Contributor

mcliquid commented Aug 2, 2024

What is your counter-proposal, or have I overlooked it?

@vsessink
Copy link
Author

vsessink commented Aug 3, 2024

Hoe about: "Is here electricity for guests"
Info box: "this can either be sockets at the pitches, or guest usable sockets in a service building"
Please note that the confusion in this discussion stems from the power_supply tag itself, which isn't clearly defined.

@rhhsm
Copy link

rhhsm commented Aug 4, 2024

Please note that the confusion in this discussion stems from the power_supply tag itself, which isn't clearly defined.

So maybe it should be defined clearly first (by starting a discussion on the community forum) and then implement it here?

@vsessink
Copy link
Author

vsessink commented Aug 4, 2024

Please note that the confusion in this discussion stems from the power_supply tag itself, which isn't clearly defined.
So maybe it should be defined clearly first (by starting a discussion on the community forum) and then implement it here?

Please see the External links above for a start. As it stands now, power_supply simply means "there is electricity usable for guests here". No definitions about at pitches or only central, paid or free, etcetera. The same goes for the streetcomplete question: it should only ask if power is available, nothing more, nothing less.

@mnalis
Copy link
Member

mnalis commented Aug 5, 2024

TL;DR: I'd prefer status quo unless tag meaning is more clearly defined by community discussion, and/or some clear (to SC users!) but overlooked solution (that hasn't been suggested yet) is found. (also I might be very slow to respond for next week or two, sorry)

What is your counter-proposal, or have I overlooked it?

@mcliquid it was "yes, it is not perfect, but seems to me the least confusing one." i.e. retain status quo (unless someone else can suggest idea which everybody agrees is less confusing than current one on all fronts)

@vsessink I guess "Is electricity generally available for all users here?" might be more to your liking? But I worry it might still be unclear for class of users that StreetComplete targets, see Quests guidelines below. Guiding them with clear example was the only way we could find workable at the time IIRC.

The same goes for the streetcomplete question: it should only ask if power is available, nothing more, nothing less.

That would be next to useless (or worse), though. Technically the answer would be yes even if e.g. (to take the extreme) only solar-powered card payment terminal exists... Yes, you can add more words to clarify, but then there are other issues mentioned earlier too, and in trying to cover all those the question become too big and unwieldy, and unsuitable for SC on those grounds.

Having this one remain as-is, and having followup quest which asks for specific sockets available would clear that up, but that looks complex.

Note the SC quest guidelines though, especially "👨‍💻 Users are no experts" and "🐿️ Easy answer".

As for info text, see:

[...] should only be used to explain doubts about (terms used in) the question itself, not mandate how the question should be answered

@rhhsm
Copy link

rhhsm commented Aug 7, 2024

The problem with the present question is that it assumes that if there is electricity that guests can use, it is most likely that it is available through common standard sockets, for instance at a common service building, and these can be used to charge a phone or a laptop. In addition, there may be electricity available at pitches (all, or only some of them) through a special socket that is not suitable for charging phones. However, even in the less common case that there is electricity only at the pitches through a special socket, the answer to the question should be "Yes" (in my interpretation of the wiki) even though you can't charge phones at them. So I agree with @vsessink suggestion: "Is there electricity available for use by guests?" with info "This could be through sockets at the pitches, guest usable sockets in a service building, etc." (mentioning "sockets" makes it clear that it should be usable by at least some of the guests, who have the right plug to fit in the socket).

@vsessink
Copy link
Author

How about:
<string name="quest_camp_power_supply_title">"Are there power supply sockets available for guests?"</string>
with a hint explaining:
<string name="quest_camp_power_supply_hint">This can be sockets at the pitches, guest usable sockets in a service building, sockets for phone/laptop charging, etc.</string>
(The hint would have to be added but as far as I understand the code that should be rather trivial).

mnalis added a commit to mnalis/StreetComplete that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants