No "What can be left here for recycling?" for recycling containers mapped as way

[fxedel]

An amenity=recycling with recycling_type=container may be mapped as a single node or as an area. While nodes are way more common (373 388) than ways/areas (10 977), there is definitely a good reason to map larger recycling container areas as an area, for example this one, which consists of 23 individual containers:

The corresponding OSM way is: https://www.openstreetmap.org/way/1276097081

Of course, also areas should be enriched with the recycling:* tags to specify what can be recycled there.

How to Reproduce
Go to an recycling container area (any overlay is fine), no quest arises.

Expected Behavior
Quest "What can be left here for recycling?" should arise.

Versions affected
v58.2

Note: If I understand PR #4936 correctly, this already works for the glass recycling quest. The fix for all recycling containers could be similar.

[westnordost]

Are you sure that it is not asked for recycling areas? Looking at the code, it certainly should. See #4907

[mnalis]

Agree with the premise that it should be asked on a ways too, and it seems to me that it is asked on other ways, as cursory look at the code would suggest it should do:

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/recycling_material/AddRecyclingContainerMaterials.kt

Lines 18 to 25 in 8636a3b

	class AddRecyclingContainerMaterials : OsmElementQuestType<RecyclingContainerMaterialsAnswer> {
	private val filter by lazy { """
	nodes, ways with
	amenity = recycling
	and recycling_type = container
	and access !~ private|no
	""".toElementFilterExpression() }

however I can confirm (in 58.1) that that it is not being asked on that specific way 1276097081 for some reason.

[mnalis]

playing in SCEE, Quest is also not shown on way 1276097081, but if I edit that way to add any unrelated tag (like level=0), suddenly the quest pops up! Could be it related to element timestamp? There is this override which perhaps might influence it? :

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/recycling_material/AddRecyclingContainerMaterials.kt

Lines 38 to 45 in 8636a3b

	override fun isApplicableTo(element: Element): Boolean =
	/* Only recycling containers that do either not have any recycling:* tag yet or
	* haven't been touched for 2 years and are exclusively recycling types selectable in
	* StreetComplete. */
	filter.matches(element) && (
	!element.hasAnyRecyclingMaterials()
	|| recyclingOlderThan2Years.matches(element) && !element.hasUnknownRecyclingMaterials()
	)

small_Screen_Recording_20240710_220709_SCEE.mp4

[westnordost]

Oh, I see the mistake. It's in line 36.

[fxedel]

Thanks for the quick fix @westnordost! ❤️