Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask what sort of boats can be rented #5426

Closed
5 tasks done
arrival-spring opened this issue Dec 28, 2023 · 4 comments · Fixed by #5741
Closed
5 tasks done

Ask what sort of boats can be rented #5426

arrival-spring opened this issue Dec 28, 2023 · 4 comments · Fixed by #5741
Assignees
@kmpoppe
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@arrival-spring
Copy link
Contributor

General

Affected tag(s) to be modified/added: *_rental=*
Question asked: What sort of boats can be rented here?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
    Canoe rental is very different to motorboat rental, it is important to be able to distinguish these
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
    Only just over 5000 amenity=boat_rental but many (>~75%?) do not have a _rental tag.

Ideas for implementation

Element selection:
amenity = boat_rental and *_rental != *

Metadata needed:
Don't think so. Maybe different boats in different countries?

Proposed UI:
Picture/icon multi-select for kayak, canoe, stand-up paddleboard, sailing boat, dinghy, motorboat and pedalboat.
@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Dec 31, 2023
@westnordost
Copy link
Member

westnordost commented Dec 31, 2023 •
edited
Loading

Sounds useful.

It should be checked if anything is missing from the list in the wiki and be added.

The biggest part of implementation will be to find icons for this that each fit and have the same style. Maybe requires drawing some oneself. I had a look:

Generally I like the one with people best, maybe because they are (of course) all of the same style. The ones that are missing (e.g. dinghy) could maybe be mashed-up from the other pictures. Starting from there:

  • icon for SUP is fine
  • icon for jetski is fine
  • icon for kayak is fine (named "canoe slalom")
  • icon for sailboat is a bit specific to a very small one - suggestion: use the https://www.svgrepo.com/svg/275483/sailboat but add that stick figure
  • icon for windsurfing, surfing, skimboarding, bodyboarding is fine (not sure if these should be part of a boatrental?)
  • rafting should probably be an own amenity?
  • canoe icon could be a mashup of the "banana boat" icon + the canoe icon?
  • houseboat could be the building icon
  • icon for dinghy could use the stick figures from "rowing 2"

@westnordost
Copy link
Member

Aw, too bad you didn't work on this in the end, I would have liked a new quest with fun new icons to select from. But for anyone who reads this, (including arrival-spring ofc), feel free to pick this up.

@kmpoppe
Copy link
Collaborator

kmpoppe commented Jul 13, 2024 •
edited
Loading

could you assign this issue to me, please?
Thanks, riQQ!

kmpoppe added a commit to kmpoppe/StreetComplete that referenced this issue Jul 14, 2024
@kmpoppe
[WIP] Add Boat Rental Quest
1745590 
Resolves streetcomplete#5426.

Known issues - feedback required:
* Order in QuestModule
* Is this a RARE achievement (only 5.3k boat_rentals tagged today)
* Answer SVGs range from 0 to 100 in my view as to their fit (I love the floaty duckboat for "pedalboard" ;-)) Wouldn't CC0 images from wikidata the better idea?
@kmpoppe kmpoppe mentioned this issue Jul 14, 2024
Merged
@westnordost
Copy link
Member

westnordost commented Jul 14, 2024 •
edited
Loading

Awesome! You know, I just bought a SUP because it's so fun to paddle in the summer and I was leaving too much money at the rentals...

The biggest part of the implementation will be to determine which kind of boats can be rented (and then finding icons for it), anyone can help here.

As my contribution to this, I checked various rentals in Hamburg for which boats they rent. In fat, boats that may be more rare:

This list got much longer than I expected. Anyway.

So, from looking through all this, I have a few comments:

  • There should probably be a "Not a rental" option, because some places that may look like rentals either exclusively offer berths and/or storeroom for owned boats (i.e. a marina, a "parking lot" for boats) and/or are water sports clubs (that don't additionally do rentals, very few do). On the other hand, one could leave a note...

  • a sailboat is not a sailboat. There should be some distinction between a sailboat you can rent for a few hours with a capacity of a few people and a sailboat that you treat basically like a camper van on water. Maybe a good line to draw would be whether the boats have a cabin or not, i.e. you can go below deck.
    Same applies to motor boats, I figure. But larger motor boats are maybe rather called yachts? Not sure.

  • I have doubts whether houseboat rentals should be treated as boat rentals, they are much more alike accommodation rentals like chalets or stationary caravans. All houseboat rentals I have found (see list above) are all moored or are probably moored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmpoppe kmpoppe

Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add Boat Rental Quest kmpoppe/StreetComplete
3 participants
@westnordost @kmpoppe @arrival-spring