Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non permanent objects: exception to "Survey if places still exist" question #5394

Closed
Kalepom opened this issue Dec 3, 2023 · 6 comments · Fixed by #5395
Closed

Non permanent objects: exception to "Survey if places still exist" question #5394

Kalepom opened this issue Dec 3, 2023 · 6 comments · Fixed by #5395
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@Kalepom
Copy link

Kalepom commented Dec 3, 2023

Hello,

That's not really a bug, but nor a new question suggestion. I hope I'm not posting in the wrong place.

The "Survey if places still exist" quest should make an exception on items with the permanent=no tag.
I'm thinking in particular of election boards (advertising=board message=political permanent=no) which are not permanently present. By answering the question "Is this object still here?", a user could risk deleting it from the database, even though the cyclicity is well defined.

Thanks

@Kalepom Kalepom added the bug label Dec 3, 2023
@matkoniecz
Copy link
Member

(also, why not just seasonal=yes or intermittent=yes ? )

@Kalepom
Copy link
Author

Kalepom commented Dec 3, 2023

It has been described on this page https://wiki.openstreetmap.org/wiki/FR:Key:permanent
It has been used in a "Projet du mois" (project of the month) task https://projetdumois.fr/projects/2017-04_electionboard

mnalis added a commit to mnalis/StreetComplete that referenced this issue Dec 3, 2023
see e.g. streetcomplete#5394 for election boards
(there is also "temporary=yes", but we want to ask for that one, as it is not expected to come back)
@mnalis
Copy link
Member

mnalis commented Dec 3, 2023

(also, why not just seasonal=yes or intermittent=yes ? )

I've just noticed that we just ship seasonal but not similar intermittent, although they should be treated the same for the existence quest (as they have same verifiability issues) :

Also I'm not sure why French community decided to use permanent=no instead of intermittent=yes, perhaps because the latter was initially intended / documented only for water bodies (and only later did it begin being used for other things too)?

Anyway, as far as StreetComplete is concerned, I've created small PR #5395 to fix both

@westnordost
Copy link
Member

Why would it be wrong to delete a non-permanent object that has been removed?

@westnordost westnordost added feedback required more info is needed, issue will be likely closed if it is not provided and removed bug labels Dec 3, 2023
@mnalis
Copy link
Member

mnalis commented Dec 3, 2023

Why would it be wrong to delete a non-permanent object that has been removed?

I've tried to document in PR text edit: as I understand it, the panels are removable, but their location is permanent because they are anchored in the ground (see e.g. https://projetdumois.fr/projects/2017-04_electionboard). So they get removed and reinstalled at the exact same place.

Another way to look at it is that it basically maps "board stand", which may or may not have (at some specific time) "board panel" installed on it. But when the users goes there "out of season", they might not look hard enough (i.e. from a distance) and declare that it is missing, while in fact it is still there.

(this is how it differs from e.g. temporary=yes, which I've also considered [and rejected], as for those it is expected to be removed and it is very welcome for SC to remove it when it is no longer present there).

westnordost pushed a commit that referenced this issue Dec 4, 2023
see e.g. #5394 for election boards
(there is also "temporary=yes", but we want to ask for that one, as it is not expected to come back)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants