Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer hiding AR quests after StreetMeasure installation fails #4849

Closed
georg-d opened this issue Feb 28, 2023 · 15 comments · Fixed by #5464
Closed

Offer hiding AR quests after StreetMeasure installation fails #4849

georg-d opened this issue Feb 28, 2023 · 15 comments · Fixed by #5464
Assignees

Comments

@georg-d
Copy link

georg-d commented Feb 28, 2023

Use case
My device Fairphone 3 is not supported by StreetMeasure. Still, in StreetComplete width/heigth quests, I get the blue camera button which prompts to install StreetMeasure – over and over again. This bothers me.
20230228 154415-StreetComplete 51 1 measurement quest

Proposed Solution
I would like to have this button vanishing completely or being greyed out – at least for some months, so I might check with newer version of StreetMeasure whether it now supports my device.

Where could the information come from whether button shall valish/disable?

  1. Obsolete: The according properties file is obviously available in StreetMeasure repository and could be included in StreetComplete. => Not feasible, as the list is closed source.
  2. After user got the promt to install StreetMeasure and returned to StreetComplete, SC could check whether SM is now an available app and if not, ask the user whether user wants to be prompted again to install SM – like this, persons how could but do not want to use SM are also not bothered any more.
@matkoniecz
Copy link
Member

See also #4795

Note that you can disable quests in settings (there are 3 AR ones, 2 about width, 1 about height, all with the measure symbol on icon, you can filter list by asked question).

@matkoniecz
Copy link
Member

The according properties file is obviously available in StreetMeasure repository and could be included in StreetComplete.

Not really, for the same reasons as StreetMeasure is a separate app (unless that part is actually open sourced)

@georg-d
Copy link
Author

georg-d commented Feb 28, 2023

@matkoniecz Thanks for linking the related issue; I didn't find it. I did strike through first solution idea.

Here, it's not about disabling the quest, just the installation prompt.

@matkoniecz
Copy link
Member

it's not about disabling the quest

but

For devices StreetMeasure does not support, disable according button

runs into the same issue as disabling the quest run into - problem of reliably checking whether device supports it or not

@westnordost
Copy link
Member

Duplicate of #4795

@westnordost westnordost marked this as a duplicate of #4795 Feb 28, 2023
@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@westnordost
Copy link
Member

so I might check with newer version of StreetMeasure whether it now supports my device.

It is rather whether the device supports StreetMeasure. Support of certain devices cannot be introduced through some update of that app.

Regarding the suggestion to hide the button under certain circumstances, I do not like it. It's like removing the camera button in the note creation dialog if there is no camera app on the device. I'd find this behavior intransparent.

@matkoniecz
Copy link
Member

Though prompt to hide this quests, if installation of StreetMeasure failed maybe would be nice?

@westnordost
Copy link
Member

Yeah

@westnordost westnordost reopened this Mar 9, 2023
@FloEdelmann FloEdelmann changed the title For devices StreetMeasure does not support, disable according button Offer hiding AR quests after StreetMeasure installation fails Mar 10, 2023
@westnordost
Copy link
Member

So, SC can not determine if the installation of an app failed. It can only see if an app of that name is installed or not. So, what could be done is to show a dialog that asks whether this quest should be disabled if:

  1. tapped on the measure-button while the app is not installed
  2. comes back to the app while the app is still not installed

However, this solution is a little dangerous, as it is a common user behavior to trigger the download and installation of an app in google play and then change apps again to let the download & install happen in the background. Especially true if you set in the settings to only download apps when on wifi.

So, the above simple check will not suffice.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Mar 10, 2023
@matkoniecz
Copy link
Member

Is it possible for SC to reenable/propose reenabling this quest once app is installed? That would mitigate this danger.

Also, wait: is any app able to check whether any other specific app is installed?

@westnordost
Copy link
Member

Also, wait: is any app able to check whether any other specific app is installed?

Yes, until Android 10 IIRC. For Android 11+, each app must specify in its manifest for which apps exactly it needs to be able to check whether it is installed.

@georg-d
Copy link
Author

georg-d commented Mar 10, 2023

So, the above simple check will not suffice.

If app is not present, why not ask users whether they want to be prompted again (see initial post). If measuring app is incompatible or undesired, users can choose "don't ask again", if app is installed in background or in future, user can choose "ask me again". The latter one may be default so users that do not read properly don't loose possibilities.

@westnordost
Copy link
Member

Well, this would show too early, IMO, as it is a completely normal use case to return to the app while (waiting to) install that app.

@westnordost
Copy link
Member

Also, for the case of my phone, the app can be installed, but when opening, it crashes (ARCore crashes).

westnordost added a commit that referenced this issue Jan 31, 2024
@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jan 31, 2024
@westnordost westnordost self-assigned this Jan 31, 2024
@westnordost
Copy link
Member

I implemented it now like this:

  • when the user taps the "measure" button while the streetmeasure app is not installed and then comes back to the app with it still not being installed, a dialog shows that offers to disable the quest

  • when the user taps the "measure" button while the streetmeasure app is installed but then the result from the app is either invalid or an error (e.g. if it crashed, as far as I know), a dialog shows that offers to disable the quest

Now, I don't like the first point too much, because some users will have the setting to only install new apps on wifi, but on the other hand, streetmeasure is both very small (2.5MB) and the user can always say no in that dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants