-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer hiding AR quests after StreetMeasure installation fails #4849
Comments
See also #4795 Note that you can disable quests in settings (there are 3 AR ones, 2 about width, 1 about height, all with the measure symbol on icon, you can filter list by asked question). |
Not really, for the same reasons as StreetMeasure is a separate app (unless that part is actually open sourced) |
@matkoniecz Thanks for linking the related issue; I didn't find it. I did strike through first solution idea. Here, it's not about disabling the quest, just the installation prompt. |
but
runs into the same issue as disabling the quest run into - problem of reliably checking whether device supports it or not |
Duplicate of #4795 |
It is rather whether the device supports StreetMeasure. Support of certain devices cannot be introduced through some update of that app. Regarding the suggestion to hide the button under certain circumstances, I do not like it. It's like removing the camera button in the note creation dialog if there is no camera app on the device. I'd find this behavior intransparent. |
Though prompt to hide this quests, if installation of StreetMeasure failed maybe would be nice? |
Yeah |
So, SC can not determine if the installation of an app failed. It can only see if an app of that name is installed or not. So, what could be done is to show a dialog that asks whether this quest should be disabled if:
However, this solution is a little dangerous, as it is a common user behavior to trigger the download and installation of an app in google play and then change apps again to let the download & install happen in the background. Especially true if you set in the settings to only download apps when on wifi. So, the above simple check will not suffice. |
Is it possible for SC to reenable/propose reenabling this quest once app is installed? That would mitigate this danger. Also, wait: is any app able to check whether any other specific app is installed? |
Yes, until Android 10 IIRC. For Android 11+, each app must specify in its manifest for which apps exactly it needs to be able to check whether it is installed. |
If app is not present, why not ask users whether they want to be prompted again (see initial post). If measuring app is incompatible or undesired, users can choose "don't ask again", if app is installed in background or in future, user can choose "ask me again". The latter one may be default so users that do not read properly don't loose possibilities. |
Well, this would show too early, IMO, as it is a completely normal use case to return to the app while (waiting to) install that app. |
Also, for the case of my phone, the app can be installed, but when opening, it crashes (ARCore crashes). |
I implemented it now like this:
Now, I don't like the first point too much, because some users will have the setting to only install new apps on wifi, but on the other hand, streetmeasure is both very small (2.5MB) and the user can always say no in that dialog. |
Use case
My device Fairphone 3 is not supported by StreetMeasure. Still, in StreetComplete width/heigth quests, I get the blue camera button which prompts to install StreetMeasure – over and over again. This bothers me.
Proposed Solution
I would like to have this button vanishing completely or being greyed out – at least for some months, so I might check with newer version of StreetMeasure whether it now supports my device.
Where could the information come from whether button shall valish/disable?
The text was updated successfully, but these errors were encountered: