Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pillar hydrant images in hydrant position quest #3686

Closed
FloEdelmann opened this issue Jan 28, 2022 · 3 comments · Fixed by #3695
Closed

Show pillar hydrant images in hydrant position quest #3686

FloEdelmann opened this issue Jan 28, 2022 · 3 comments · Fixed by #3695

Comments

@FloEdelmann
Copy link
Member

FloEdelmann commented Jan 28, 2022

Originally posted by @mpawelski in #3368 (comment):

Use case

When being asked about the position of a fire hydrant with fire_hydrant:type=pillar, the selectable images only show underground hydrants. This confuses users.

Proposed Solution

If fire_hydrant:type is pillar, show pillar hydrant images and possibly (if no image can be found) hide the "parking spot" option.
For fire_hydrant:type=underground, keep the existing images.

Possible images

@westnordost
Copy link
Member

westnordost commented Jan 28, 2022

Pictures looks good. I wanted to reply that the on-street fire hydrant looks like it is on (asphalted) sidewalk. But I checked the location, it is the street. Interestingly, it doesn't seem to exist anymore now:

https://www.google.de/maps/@45.8200067,10.5385954,3a,48.3y,274.67h,53.79t/data=!3m6!1e1!3m4!1s-jBfM3QkHQVzxCMCgqID7g!2e0!7i13312!8i6656

Edit: Nevermind, the google pictures are older, it didn't exist back then.

@mnalis
Copy link
Member

mnalis commented Jan 28, 2022

I have seen one on parking lot just the other day, I can go and take picture of that.

@mnalis
Copy link
Member

mnalis commented Jan 29, 2022

Something like this (I have few other angles if needed). CC-BY 4.0
IMG_20220129_133104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants