-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What type of Stile/Gate/Gap is here? #3372
Comments
It can appear also in city. Hopfefully number of false positives where existing mapping is wrong is low... Not sure what would be the best but maybe separate quest reusing assets would be better to allow disabling/enabling this one separately. And would allow a more precise title(s).
Only where it intersects. Note not-fully-mapped bridges and tunnels. |
Good point, I don't think there should be other answers there.
How do you mean? Where they don't cross?
Yeah fair point, is there some cleverer way we can use identical code but just two different sets of node queries?
I think you can do that already can't you, like the tram/bus quests?
Having looked, the top of my two example nodes just crosses and doesn't intersect. Curiously iD doesn't flag that as a warning... |
For example where there is a hedge, very large gap (50m? 20m?) with footway inside and then another hedge. With hedge mapped as one line intersecting with footway.
Yes, but everything gets far more complex. Maybe I will start from implementing a separate quest and then refactor and merge it. But given that query, title and rate of potential issues I think that separate quest is fine. Someone may wish to disable as their area is unlucky to have many false positives, finding quest with title not shown in quest list would be weird and so on. |
Ah I see, which would hopefully generate a note and have the mapping corrected.
Yeah that makes sense.
Although I think you have to have the tram and bus quests combined. |
One more consideration: should it be asked when barrier terminates on intersection? Or is touching but not crossing? This kind of filter is implemented already for crossing quest, not sure is it worth using. Maybe just take all intersections? This cases should be rare and result in notes.
And I quite dislike it, I got confused at least once - despite that I have written parts of it |
I would go for
|
I was sort of assuming we'd just take it (although I agree it should be rare/is likely to be some incorrect/incomplete mapping), but if someone has developed the logic I don't see why we can't just steal it.
With path/footway being dynamic substitution of the relevant term? I think this is slightly more grammatically correct: |
likely not - question objects will be nodes on intersection and topology is (I think) lost when title is shown, so it cannot be set. And anyway |
Is this because it's only technically possible to check for intersection, or just because it's more appropriate for this quest? |
Primarily to avoid asking confusing questions about broken data and possibly breaking it even more. |
Ah, in which case is it better if we come up with a more generic term, in case we add other similar matches?: |
way/route is a bit too generic - as it includes also roads path - would it inclde in English also paved footways? |
Do you mean the ones that run alongside roads for cars (a.k.a. pavements, or sidewalks in en-US)? If you do, I imagine most people would understand it, but I'm not sure how many would actually say it in that case. |
This ones are unlikely to encounter barriers, so I was thinking rather about ones going without road along them. Like this paved park footway - is user going to be confused and create note when asked about it?: In Polish translation I will use "ścieżka/chodnik" as both very strogly indicate surface ("ścieżka", Polish for path strongly indicates |
Not according to the dictionary: I'd probably think it's a bit more at the muddy end, but I can't immediately think of one specifically for paved routes. @smichel17 @andrewharvey |
In everyday English (at least where I'm from: England), no-one uses the word footway. If it is ever used, it will be referring to the path alongside the road which is normally called the pavement ( A path can have any sort of surface, I think. At some point, you might end up calling it a track (particularly if it is paved and/or wider (for vehicles) and/or also for cycles). In my experience Like @peternewman, I also can't think of a word for paved paths. |
Funnily enough, I'd say a track is something wider, but unpaved, so you might send a 4x4 through a track in the woods. I'd probably call it a road if it's well paved (but maybe concrete slabs/lanes would be a farm track). |
Preface: In common English, I think all of these words are ambiguous enough that there are no individual combinations egregious enough that I would be forced to ask for clarification. We're mostly talking about what I would assume if someone were not fully explicit. (Also, this got way longer than I intended, somehow. 🤷 )
+1 from the northeast United States.
Also sidewalk in American English. Pavement should be reserved for en-GB translations. Before discussions on this tracker, I'd never heard it used to mean sidewalk, and I was genuinely confused (could not figure out the meaning) the first time I heard it. In America, pavement refers to the paved surface of the road (usually asphalt, although maybe that's just because most roads are asphalt here). I imagine this impression comes from I would still understand you if you used it to refer to the surface of a sidewalk. However, I would assume you were talking about the road surface if you didn't specify it explicitly with "sidewalk pavement" (this is what confused me the first time).
Both paved and unpaved paths are common.
I cannot speak definitively about this word since I have seen it too much in SC. I think it is fairly uncommon, and I would mostly expect to hear tracks referred to as some kind of road instead (e.g. "logging road"), but I need to ask others to confirm. |
I think that I will extend it to (why separate quest for roads? Because it is typical to have gate for road and separately mapped path without a barrier along it) |
Wow, I expected it to be a niche quest with thousands question generated worldwide. But still worth it due to high importance. But https://overpass-turbo.eu/s/1daL reveals many more cases than I expected. Including some tricky ones like https://www.openstreetmap.org/node/206351942 https://www.openstreetmap.org/way/692929794 (a tunnel entrance) that right now would qualify. I guess that excluding nodes that are touched by |
Same case with bridges, see https://www.openstreetmap.org/node/78135912 or https://www.openstreetmap.org/way/28101153. |
Thanks! I just excluded all bridges, too many false positives here. |
General
Affected tag(s) to be modified/added: stile
Question asked: What type of Stile/Gate/Gap is here?
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
Element selection:
Anywhere where a
highway=path/footway
intersects/crosses abarrier=wall/fence/hedge/guard_rail
For example this node (and the one above it):
https://www.openstreetmap.org/node/7287751590
Metadata needed:
None
Proposed UI:
It can probably just chuck you into the existing stile quest, especially when gaps are added as mentioned in #3188 (comment)
The text was updated successfully, but these errors were encountered: