Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better display of statistics, show how things changed #3230

Closed
matkoniecz opened this issue Aug 30, 2021 · 4 comments · Fixed by #4572
Closed

better display of statistics, show how things changed #3230

matkoniecz opened this issue Aug 30, 2021 · 4 comments · Fixed by #4572

Comments

@matkoniecz
Copy link
Member

idea by @westnordost

show progress (how number changed) on opening stat screen. E.g. if you are now rank #100 instead of rank #125 since you last visited that screen, it would be nice if this change is animated (in a fun way?) instead of it being displayed as if it has always been that way

If anyone is aware about some open source project implementing such display - let me know

@westnordost
Copy link
Member

westnordost commented Aug 30, 2021

If anyone is aware about some open source project implementing such display

What display exactly? Animations are part of Android. If you want to animate counting from e.g. 125 down to 100, that can be done with normal animators, see QuestTypeInfoFragment.

Nicer than that would be perhaps something like a tally counter (i.e. the numbers animate in and out from above and below)

Would you agree?

Actually, maybe not only for that, but also for the counter in the quest statistics dialog and for the star counter.

I searched quickly if there is any lib for that and didn't find any. But actually, it should be pretty straightforward to implement it as a custom view. An example of a custom view that draws itself using the canvas is the VerticalLabelView

The view could accept a decimal number instead of an int, even though it only shows integers. Setting a decimal like e.g. 1234.5 would lead to the view being displayed as the first 3 digits being 1 2 3 and the last one halfway from 4 to 5. With this behavior in place, adding animation to that is easy, using the same method as we use now: With animators.

@mnalis
Copy link
Member

mnalis commented Aug 30, 2021

Sounds like a nice touch, but do note that it might be demotivating too (after all, usually for each user that gained rank, all other users who are now below him/her had to lose rank).

Eg. if you didn't contribute for some days and go on a multi-hour mapping session, and then visit the statistics, only to see your position counter counting in animation to worse position - sounds like it might be demotivating for some users at least.

Maybe only do the animation if the position of the user actually improved ?

@westnordost
Copy link
Member

Maybe only do the animation if the position of the user actually improved ?

Yeah, good idea

@matkoniecz
Copy link
Member Author

matkoniecz commented Oct 18, 2021

Maybe only do the animation if the position of the user actually improved ?

+1

after all, usually for each user that gained rank, all other users who are now below him/her had to lose rank

Though among active mappers overall change will be positive, or expected. Among actively contributing mappers overall change will be positive.

And there are noncompetitive statistics like days of mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants