-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many bollard quests in rows of bollards #3017
Comments
I just tried another place where there is a row of bollards, but unexpectedly there wasn't a bunch of quests. So I looked at the quest's code more detailed, and found it already excludes free-floating nodes. It must be the chain in the example above which triggered the quest. Maybe just filter out StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/bollard_type/AddBollardType.kt Line 29 in c9367d3
Could possibly be extended by .filter { it.tags["barrier"] != ". *" } (I'm not sure about the syntax) I don't understand why areas are excluded at the moment, though. |
Or allow only bollards on |
That was my first idea, but as I saw the current filter is less restrictive, I thought that it may be an advantage being less restrictive. But most important to me are untagged ways which are part of |
What do @FloEdelmann and @RubenKelevra think? |
Well the target information we like to get from around the world is if a path or a highway can be driven on by an ambulance or other emergency vehicles or if its permanently blocked by a non-removable bollard. I think we might want to flip the filter and do a whitelist on |
Here is a similar case: Don't get me wrong, this info is still collectable, since with a row a user can identify the n pole of the barrier, but this is not helpful for routing. Additionally the users might collect wrong information if there are a lot of poles in a row due to the fact that they are not rendered. |
…mplete#3017)" This reverts commit 267ee3b.
Use case
Sometimes there are long rows of bollards, where each bollard is tagged
barrier=bollard
. This creates a lot of bollard type quests.This example is a chain which is supported by bollards. Each bollards is mapped as a
barrier=bollard
, and all of them are part of a way taggedbarrier=chain
.Also, if there is a street crossing a line of bollards, often only the bollards which are in the center of the road are removable. I fear surveyors may start at the end of the the bollard row, starting to answer the quests. After the first few fixed bollards they get tired of looking at each bollard thoroughly, and solve all other quests by choosing fixed. Thus, they may incorrectly also tag the crucial bollard as fixed, even though it is removable.
Proposed Solution
Only show the bollard type quest for nodes which are part of at least one
highway=*
-way, which should be simple. Those bollards are the ones which are important for routing.Maybe also ask for nodes which are part of a way which is part of a
highway=*
-relation, e.g. a pedestrian area Multipolygon. But that's probably more complicated.The text was updated successfully, but these errors were encountered: