Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add answer "Does not exist anymore" to the building type quest. #2719

Closed
andrewharvey opened this issue Apr 2, 2021 · 6 comments
Closed
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@andrewharvey
Copy link
Contributor

Suggestion to add a "Does not exist anymore" answer to the building type quest to mark buildings that did exist but are now demolished/razed buildings. I realise this would only capture a small group of buildings that were still building=yes and demolished before anyone tagged the building type, but it does happen.

Ideally these would be tagged as demolished:building=yes or razed:building=yes or removed:building=yes so that armchair mappers looking at imagery which has the building can see a surveyor has checked it as no longer there.

@ygra
Copy link

ygra commented Apr 2, 2021

You can just say »cannot answer this« and leave a note, I guess. It's not like building disappearing is that frequent compared to the alternatives.

@andrewharvey
Copy link
Contributor Author

You can just say »cannot answer this« and leave a note, I guess. It's not like building disappearing is that frequent compared to the alternatives.

Yeah I realise that, but I feel it's better to have an answer there as it get's automatically tagged and easier than addressing notes later.

Now that I know "Cannot answer" just leaves a note it's okay, but before this I'd often not choose that because I can answer it, it's just the answer is "Something else". So I feel two options "Cannot answer" and "Something else" would be better. But this is off-topic here.

@westnordost
Copy link
Member

westnordost commented Apr 2, 2021

Yes, in this case it is better to leave a note. It was kind of deliberate to exclude "larger" things from direct deletion.

Moreover, currently, it is only possible to remove POIs (that is: nodes), not ways, not relations.

Removing these is more complex, as usually if you remove a building, you also want all the vertices of that building removed, too. But only those vertices that are not used by any other way. Also, if the building is a multipolygon relation (yes, they appear as quests in StreetComplete too), then it is even more complex: All members of that relation should (probably) also be removed, including their nodes, except if they are referenced by anything else (other ways, other relations)

So of course, this could be implemented, and it would not be too hard, but leaving note in this case is really equally good or better than deleting it directly.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Apr 2, 2021
@andrewharvey
Copy link
Contributor Author

Removing these is more complex, as usually if you remove a building, you also want all the vertices of that building removed, too. But only those vertices that are not used by any other way. Also, if the building is a multipolygon relation (yes, they appear as quests in StreetComplete too), then it is even more complex: All members of that relation should (probably) also be removed, including their nodes, except if they are referenced by anything else (other ways, other relations)

Another reason for just retagging as razed:building=*, better for OSM mappers, easier for SC.

@kmpoppe
Copy link
Collaborator

kmpoppe commented Mar 2, 2022

With this coming up in #3823 again, wouldn't it be worth an other answer "does not exist anymore" and then either show a message box explaining what to do (leave a note) much like the "No cycleway at all" answer in AddCycleway and/or allow the user to directly forward to a note window with the text "This building seems to no longer exist" pre filled?

@smichel17
Copy link
Member

smichel17 commented Mar 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

5 participants