-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest for type of building #25
Comments
Yes and yes. For mobility access, please create a separate ticket. The problem (and the reason why I haven't implemented it yet) is that there are is a heap of different building types. So I don't how I can best find the balance between keeping it simple & clear and enabling the user to always give a precise and correct anser (= presenting him all the options). |
I certainly see what you mean. It is not an easy design decision. Would a scrolling menu work well to choose a tag? iOS has the tumbler. |
Well I thought about something like the roof selector (pictures or pictures with text), only grouped by category: Residential, Commercial, industrial etc. I am doing the same now with street surfaces. But perhaps not everything fits into categories like that (is a Church, a Hospital,... residential or commercial?) |
Yes, buildings can have the value of house, apartments, church, temple, hospital, university, and more. All these are valid for "building=*". Maybe they could be categorized further for the UI: Education -> school, university; The objective would be to channel users through the complexity of these tags and there intended use. Not an easy one but this could be brainstormed! |
Currently looking in Ottawa I think the quest looks at building levels. Could different quests do different things? If so then simple things can be given to new mappers but more complex things such as building type to more experienced mappers. ie you have to have used something for more than 30 minutes? |
Yes of course. This ticket is about adding a new quest where the user specifies the building type. |
For this specific quest note that the For example See Key:building (with its talk) and Buildings on the Wiki. |
I would like to see this quest implemented |
From #297
Is there a list of required photos (it would not be really useful to search for ones that already have a good photo...)? |
Hi, here is my mockup for "accommodation" buildings (remarks are welcome) : |
The icons are well thought through, I would probably understand what is meant without the text. I am not sure though if the "average user" which doesn't know the OSM categories would. (Though I do not understand "house". Doppelhaushälfte?) Also, why not photos? |
I choosed icons to get rid of architectural and cultural aspects. I think icons are understandable by more people. In my concern, pictures are less "readable". 😄 |
And yes, I do not really understand the difference between house and detached. The wiki is not very precise. |
I really like the icons. Don't think photos would work in this size. |
Nici icons but the picture for house looks like a one for semi-detached house (which is missing and those are pretty common in Poland). During my mapping I use building=house as a more specialized version of building=yes, that is a place where people live. |
@krzyk What is the tag for a semi-detached house in your opinion? According to the building wiki page =house is semi-detached (aka two family side by side building). But according to the =house wiki it is a generic one family building but could also be semi-detached. 8-/ The generic "living house" (regardless the amount of families) is not =house but =residential... |
I think there are two level of generalization:
Also As written in the wiki |
Because of this unclear definition, I have always been mapping any kind of building where one family has its own living unit (so probably house, detached, semi-detached, terrace) simply as house. I think it is quite common, at least in my area, to use house for what would probably actually be detached.
This is probably because "house" is used in actual lamguage and everyone knows what is meant with it, noone says "I am going back to my detached".
Also, the definition "should share at least two nodes with another house" is shit. If this is supposed to be the difference bezween detached/semi-detached and house, then this is duplicate information: That info is already in the geometry!
All in all, I am for only showing house, the other stuff is to confusing. Not even for us OSMlers it is clear.
Am 8. Juni 2017 08:57:57 MESZ schrieb NonnEmilia <[email protected]>:
…I think there are two level of generalization:
1. Residential: including apartments, terrace, houses, ...
2. House: including detached, farm, ...
Also `building=house` is another way to tag `building=terrace` because
`building=terrace` is for the entire row of houses, but you could not
tag them as `building=terrace` but as many single `building=house`s
attached to each other.
As written in the wiki `building=house` "should share at least two
nodes with joined neighbours". Not so simple to explain it with an
image... 😞
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#25 (comment)
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
|
Another compromise is to exclude "Detached" from the options. If anyone want to be more specific and tag detached houses as |
Detached is a single family home in North America. House is either detached or semi-detached. I would keep the distinction. Detached means detached, house is a more general term that includes detached so dropping detached would mean loss of detail. John |
I totally agree with you in fact I said that is a compromise, a compromise
between details and simplicity.
I am proposing to keep a little level of details in this app (and don't
have only an "House" button) and delegate the more complex detail level to
any other more complete OSM editor (JOSM, iD, ...).
I personally like the actual simplicity of StreetComplete.
2017-06-08 18:25 GMT+02:00 johnwhelan <[email protected]>:
… Detached is a single family home in North America. House is either
detached or semi-detached. I would keep the distinction. Detached means
detached, house is a more general term that includes detached so dropping
detached would mean loss of detail.
John
|
But in Canada Stats Canada is helping feed building information into OSM
and they'd like as much detail as they can get. If streetcomplete is
unable to provide the level of detail they would like then they will look
for other solutions. Currently much of Ottawa has had details added to
buildings using streetcomplete and they are looking to expand across Canada.
Some Montreal economists are very excited about the building information
and using it. Zambia local government is also looking at it.
Stats is using what I call non-mappers to gather its building data but
wants the data to be as rich as possible.
We don't normally think about what the data in OSM will be used for but in
this case it is worth thinking about. The value is there.
Cheerio John
…On 8 June 2017 at 12:49, NonnEmilia ***@***.***> wrote:
I totally agree with you in fact I said that is a compromise, a compromise
between details and simplicity.
I am proposing to keep a little level of details in this app (and don't
have only an "House" button) and delegate the more complex detail level to
any other more complete OSM editor (JOSM, iD, ...).
I personally like the actual simplicity of StreetComplete.
2017-06-08 18:25 GMT+02:00 johnwhelan ***@***.***>:
> Detached is a single family home in North America. House is either
> detached or semi-detached. I would keep the distinction. Detached means
> detached, house is a more general term that includes detached so dropping
> detached would mean loss of detail.
>
> John
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#25 (comment)
307155602>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
ACsAktaOHfw9OoAVZllUmDJ8GFDc97Tgks5sCCB_gaJpZM4MpKcW>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACUNa8iA2PJQh0KpvGwxZr_iYJ73GYkEks5sCCX-gaJpZM4MpKcW>
.
|
The problem with the second proposal is that "residential" is clearly a category which can be made more detailed while house is not necessarily a category (...right?) but that setup would suggest that it is. There is always the possibility to create another quest to let the user specify "what kind of house" something is. Offering too many choices may only confuse the user and make the selection more tedious. Rather than trying to cover everything at once, quests should be designed to be easily answerable and be designed for the majority of cases. I.e. the very vast minority of all residential buildings will be house boats, bungalows or static caravans. Those could either be shown only after pressing a certain button or not at all (-> user must open a note and describe what building it is). Anyway, the difficult part about this quest will be to where to draw the line between a building type that is still being displayed as a choice and those that are not since there are myriads. |
Here is a possible way to solve the problem. There are 56 values for tag building. Here is my current "categorization". Remarks are welcome. So i am thinking of a screen that shows 7 buttons : Residential; Services/Civic; Religious; Commercial; For Cars; Farm; Sport; Other When you tap on one of that 7 buttons, a specific popup is open and you can choose between tags. |
I would expect hotel in services. |
Also, I am not entirely sure whatever horrible building=ruins tagging scheme deserves to be promoted. |
@matkoniecz @krzyk @openbrian In theory, a good idea. But for many of these categories, a documented tag is missing. I wouldn't want to create a |
By now, there seems to be another issue with buildings. I get no quests about housenumbers if the tagging is only "building=yes". And i've seen lots of them by now so this is an important quest. |
What you mean, might be an "expert mode" as requested in #471. |
Currently my opinion about how this quest type should be implemented is this: Simply show a plain list with images (like for the roof shapes quest) with the most-used tags for For all the less frequent values (at some point we need to make a cut), the user will have to leave a note. There could be a "Other answer" option named "Other kind of building" in which the user has to describe the kind of building and that does actually leave a note. Though, I am still unsure on how to deal with the odd situation with "categories" that are not really categories because not all values are categorized and for others, no generic tag for that category exists (see #25 (comment)). |
Too many types would just be confusing. I would prefer to have only the most common types. I would guess that >90% of the buildings I see are either house, apartaments or office buildings. |
This is a great point. In OSS we often declare all options equally important, but realistically there are only a few building types that make up the majority of buildings out there. |
My worry is that a two level interface like the one for road surface would be too cumbersome. It's OK for roads, where you have to select once in a while during your walk. But for buildings, where you will probably have to select a new one every few steps, the interface should be minimal. Maybe 3 or 4 most common building types on the first level, with an "other" button for churches, schools and so on. |
Or you just place the top-3 at the top, so optionally a user can still select the pother types. |
The main problem here is what to do if the user cannot specify tge type of building beyond "it is a building" - i.e. it may be a commercial building or also a residential building or even just a retail building etc...
Am 21. Dezember 2017 00:49:48 GMT+07:00 schrieb rugk <[email protected]>:
…Or you just place the top-3 at the top, so optionally a user can still
select the pother types.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#25 (comment)
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
|
There should be a quickly and directly accessible icon for the most frequent types like "house" and "garage" (to easily convert building=yes into building=house which require housenumbers or building=garage which does not require housenumbers) and a button "other" which invokes a submenu, with other frequently used building types with icons and names (similar to sports types). And there should be a "cannot answer" button with the option to create a note. |
Yes, I am implementing the quest like this now! |
Interesting conversations about building types. I guess this app has the ability to spread much more detailed information throughout the database, so the first implementation should be very well to understand, to avoid mass misstagging. I see some issues here for example in residential buildings, build in a row inside a city with shops in the first level. How should such a building be tagged? 🤔 From a user perspective this opens at least 5 possibilities: residential, house, commercial, retail, terrace. So each user might select different on their view onto the world. I think we should approach it differently: we collect pictures of buildings as a crowd and agree on each of them how we should tag them. So we might end up with some more good pictures than values, but completely cover all edge-cases. |
Have you noticed #774? This should answer most of your proposals...
This should be the intention behind every quest 👍
which is why we decided to use icons rather than images and a show a small description next to the icon like you can see in #774 (comment) |
Thanks for your work on this topic, I actually overlooked this PR here in the list. Thanks for the heads-up |
Your app shows for building type = semidetached_house the whole building (2 households) as one object. This ist not what the wiki and osm.org think it is. They interpret this tag as "half of the semidetached house" or "house attached to another house on one side" (german "Doppelhaushälfte" statt "Doppelhaus"). |
|
Thank you! I prefer your Doppelhaus-interpretation anyway :) |
(me too, because the Doppelhaushälfte interpretation would not be that compatible with simple 3d buildings. According to simple 3d buildings, anything that shares a wall and at least things that share a roof should be one |
I am very impressed with this app. I have a couple of questions for you.
Is it possible to have a quest for the type of buildings? This is one of the most missing information about buildings. Could a quest be added for mobility access too?
The text was updated successfully, but these errors were encountered: