Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest for type of building #25

Closed
Monduiz opened this issue Mar 25, 2017 · 54 comments · Fixed by #1092
Closed

Quest for type of building #25

Monduiz opened this issue Mar 25, 2017 · 54 comments · Fixed by #1092
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Milestone

Comments

@Monduiz
Copy link

Monduiz commented Mar 25, 2017

I am very impressed with this app. I have a couple of questions for you.

Is it possible to have a quest for the type of buildings? This is one of the most missing information about buildings. Could a quest be added for mobility access too?

@westnordost
Copy link
Member

westnordost commented Mar 25, 2017

Yes and yes. For mobility access, please create a separate ticket.

The problem (and the reason why I haven't implemented it yet) is that there are is a heap of different building types. So I don't how I can best find the balance between keeping it simple & clear and enabling the user to always give a precise and correct anser (= presenting him all the options).

@Monduiz
Copy link
Author

Monduiz commented Mar 25, 2017

I certainly see what you mean. It is not an easy design decision.

Would a scrolling menu work well to choose a tag? iOS has the tumbler.

@westnordost
Copy link
Member

Well I thought about something like the roof selector (pictures or pictures with text), only grouped by category: Residential, Commercial, industrial etc.

I am doing the same now with street surfaces. But perhaps not everything fits into categories like that (is a Church, a Hospital,... residential or commercial?)

@Monduiz
Copy link
Author

Monduiz commented Mar 25, 2017

Yes, buildings can have the value of house, apartments, church, temple, hospital, university, and more. All these are valid for "building=*".

Maybe they could be categorized further for the UI:

Education -> school, university;
Worship -> church, shrine, temple, synagogue, mosque, cathedral, chapel
Residential -> residential, house, apartments, bungalow, static_caravan;
Commercial -> commercial, hotel, bakehouse, etc.
Industrial -> industrial, farm,
storage-distribution -> warehouse
Other -> civic, hospital, train_station, transport, etc.

The objective would be to channel users through the complexity of these tags and there intended use. Not an easy one but this could be brainstormed!

@johnwhelan
Copy link

Currently looking in Ottawa I think the quest looks at building levels.

Could different quests do different things?

If so then simple things can be given to new mappers but more complex things such as building type to more experienced mappers. ie you have to have used something for more than 30 minutes?

@westnordost
Copy link
Member

Yes of course. This ticket is about adding a new quest where the user specifies the building type.

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Apr 3, 2017
@NonnEmilia
Copy link

For this specific quest note that the building=* key is intended (mainly) for the building typology rather than the building usage.

For example building=farm is a typical residential building inside a farm, not an "industrial" one.

See Key:building (with its talk) and Buildings on the Wiki.

@zxmon21
Copy link

zxmon21 commented May 20, 2017

I would like to see this quest implemented

@matkoniecz
Copy link
Member

From #297

If you want to push towards that #25 is implemented (it will be sooner or later), you can contribute by searching for good and representative pictures for all the buildings. The ones in the wiki are not always good and generic enough to be representative (worldwide).

Is there a list of required photos (it would not be really useful to search for ones that already have a good photo...)?

@Binnette
Copy link
Contributor

Binnette commented Jun 7, 2017

Hi, here is my mockup for "accommodation" buildings (remarks are welcome) :
accommodation

@westnordost
Copy link
Member

westnordost commented Jun 7, 2017

The icons are well thought through, I would probably understand what is meant without the text. I am not sure though if the "average user" which doesn't know the OSM categories would. (Though I do not understand "house". Doppelhaushälfte?)
In my mind, I sketched a slightly different view: Instead of quadratic icons in a grid, have a list of items which each have an icon/photo on the left and a sentence of explanation that fills the right side because after reading the wiki page, I had the impression that each category needs some explanation.
(But I didn't put much thought into that, I just thought that more text-space might be necessary)

Also, why not photos?

@Binnette
Copy link
Contributor

Binnette commented Jun 7, 2017

I choosed icons to get rid of architectural and cultural aspects. I think icons are understandable by more people. In my concern, pictures are less "readable". 😄

@Binnette
Copy link
Contributor

Binnette commented Jun 7, 2017

And yes, I do not really understand the difference between house and detached. The wiki is not very precise.

@HolgerJeromin
Copy link
Contributor

I really like the icons. Don't think photos would work in this size.
=house is not well named, but I also use them for buildings which share a wall with one other residential building.

@krzyk
Copy link
Contributor

krzyk commented Jun 8, 2017

Nici icons but the picture for house looks like a one for semi-detached house (which is missing and those are pretty common in Poland). During my mapping I use building=house as a more specialized version of building=yes, that is a place where people live.

@HolgerJeromin
Copy link
Contributor

@krzyk What is the tag for a semi-detached house in your opinion?

According to the building wiki page =house is semi-detached (aka two family side by side building). But according to the =house wiki it is a generic one family building but could also be semi-detached. 8-/

The generic "living house" (regardless the amount of families) is not =house but =residential...

@NonnEmilia
Copy link

I think there are two level of generalization:

  1. Residential: including apartments, terrace, houses, ...
  2. House: including detached, farm, ...

Also building=house is another way to tag building=terrace because building=terrace is for the entire row of houses, but you could not tag them as building=terrace but as many single building=houses attached to each other.

As written in the wiki building=house "should share at least two nodes with joined neighbours". Not so simple to explain it with an image... 😞

@westnordost
Copy link
Member

westnordost commented Jun 8, 2017 via email

@Binnette
Copy link
Contributor

Binnette commented Jun 8, 2017

So, maybe it's better like this. With 2 groups :

  1. Residential: Apartments; Dormitory; Hotel
  2. House: Detached; Farm; Terrace; Houseboat; Bungalow; Static caravan

Note that, user can also select Residential or House.

accommodation b

Here is an other proposition for group "House" with a question mark :
house

@NonnEmilia
Copy link

Another compromise is to exclude "Detached" from the options.
building=detached may create confusion with building=house, but according to the current schema building=house is a superset of building=detached so there's no data loss and the result is more KISS.

If anyone want to be more specific and tag detached houses as building=detached will use an advanced OSM editor.

@johnwhelan
Copy link

Detached is a single family home in North America. House is either detached or semi-detached. I would keep the distinction. Detached means detached, house is a more general term that includes detached so dropping detached would mean loss of detail.

John

@NonnEmilia
Copy link

NonnEmilia commented Jun 8, 2017 via email

@johnwhelan
Copy link

johnwhelan commented Jun 8, 2017 via email

@westnordost
Copy link
Member

westnordost commented Jun 8, 2017

The problem with the second proposal is that "residential" is clearly a category which can be made more detailed while house is not necessarily a category (...right?) but that setup would suggest that it is.
Anyway, house is clearly a sub-choice of residential, having it alongside residential seems wrong to me.

There is always the possibility to create another quest to let the user specify "what kind of house" something is. Offering too many choices may only confuse the user and make the selection more tedious.

Rather than trying to cover everything at once, quests should be designed to be easily answerable and be designed for the majority of cases. I.e. the very vast minority of all residential buildings will be house boats, bungalows or static caravans. Those could either be shown only after pressing a certain button or not at all (-> user must open a note and describe what building it is).
Splitting up this quest into first selecting whether this building is residential, commercial, industrial or something else and then have other quests to further add detail might uncomplicate this issue. Though, I think, the problem with that approach would be that not for all buildings, a taggable "category" exists.
A third option could be to only show the very common values for i.e. residential (house, apartments,..) etc. and only if the user chose "residential", show another quest to specify the exact type of residential in which all the options are displayed later.

Anyway, the difficult part about this quest will be to where to draw the line between a building type that is still being displayed as a choice and those that are not since there are myriads.

@Binnette
Copy link
Contributor

Binnette commented Jun 8, 2017

Here is a possible way to solve the problem. There are 56 values for tag building. Here is my current "categorization". Remarks are welcome.

So i am thinking of a screen that shows 7 buttons : Residential; Services/Civic; Religious; Commercial; For Cars; Farm; Sport; Other

When you tap on one of that 7 buttons, a specific popup is open and you can choose between tags.

tab

@matkoniecz
Copy link
Member

I would expect hotel in services.

@matkoniecz
Copy link
Member

Also, I am not entirely sure whatever horrible building=ruins tagging scheme deserves to be promoted.

@westnordost
Copy link
Member

@matkoniecz @krzyk @openbrian In theory, a good idea. But for many of these categories, a documented tag is missing. I wouldn't want to create a :streetcomplete namespace nor invoke the wrath of people watching over building-tag-values.

@bitboy85
Copy link

By now, there seems to be another issue with buildings. I get no quests about housenumbers if the tagging is only "building=yes". And i've seen lots of them by now so this is an important quest.
To Keep it simple but correct you can add "simple" or "advanced" view of possible answers.
simple just contains the most common ones (if ist wrong, that could also happen if a user directly edit osm and don't know all possible taggings). The advanced view contains all possible values with easy to understand icons like the ones from Binnette.

@rugk
Copy link
Contributor

rugk commented Sep 20, 2017

What you mean, might be an "expert mode" as requested in #471.

@westnordost
Copy link
Member

westnordost commented Nov 20, 2017

Currently my opinion about how this quest type should be implemented is this:

Simply show a plain list with images (like for the roof shapes quest) with the most-used tags for building, sorted by likeliness ("house" etc at the top).

For all the less frequent values (at some point we need to make a cut), the user will have to leave a note. There could be a "Other answer" option named "Other kind of building" in which the user has to describe the kind of building and that does actually leave a note.

Though, I am still unsure on how to deal with the odd situation with "categories" that are not really categories because not all values are categorized and for others, no generic tag for that category exists (see #25 (comment)).

@westnordost westnordost added this to the v4 (planned) milestone Nov 28, 2017
@afmenez
Copy link

afmenez commented Dec 18, 2017

Too many types would just be confusing. I would prefer to have only the most common types. I would guess that >90% of the buildings I see are either house, apartaments or office buildings.

@openbrian
Copy link

This is a great point. In OSS we often declare all options equally important, but realistically there are only a few building types that make up the majority of buildings out there.

@afmenez
Copy link

afmenez commented Dec 19, 2017

My worry is that a two level interface like the one for road surface would be too cumbersome. It's OK for roads, where you have to select once in a while during your walk. But for buildings, where you will probably have to select a new one every few steps, the interface should be minimal. Maybe 3 or 4 most common building types on the first level, with an "other" button for churches, schools and so on.

@rugk
Copy link
Contributor

rugk commented Dec 20, 2017

Or you just place the top-3 at the top, so optionally a user can still select the pother types.

@westnordost
Copy link
Member

westnordost commented Dec 21, 2017 via email

@padan
Copy link

padan commented Jan 24, 2018

There should be a quickly and directly accessible icon for the most frequent types like "house" and "garage" (to easily convert building=yes into building=house which require housenumbers or building=garage which does not require housenumbers) and a button "other" which invokes a submenu, with other frequently used building types with icons and names (similar to sports types). And there should be a "cannot answer" button with the option to create a note.

@ENT8R
Copy link
Contributor

ENT8R commented Jan 25, 2018

Yes, I am implementing the quest like this now!

@RubenKelevra
Copy link
Contributor

Interesting conversations about building types. I guess this app has the ability to spread much more detailed information throughout the database, so the first implementation should be very well to understand, to avoid mass misstagging.

I see some issues here for example in residential buildings, build in a row inside a city with shops in the first level. How should such a building be tagged? 🤔

From a user perspective this opens at least 5 possibilities: residential, house, commercial, retail, terrace. So each user might select different on their view onto the world.

I think we should approach it differently: we collect pictures of buildings as a crowd and agree on each of them how we should tag them. So we might end up with some more good pictures than values, but completely cover all edge-cases.

@ENT8R
Copy link
Contributor

ENT8R commented Apr 23, 2018

Have you noticed #774? This should answer most of your proposals...

so the first implementation should be very well to understand, to avoid mass misstagging.

This should be the intention behind every quest 👍

From a user perspective this opens at least 5 possibilities

which is why we decided to use icons rather than images and a show a small description next to the icon like you can see in #774 (comment)

@RubenKelevra
Copy link
Contributor

Thanks for your work on this topic, I actually overlooked this PR here in the list. Thanks for the heads-up

@Nielkrokodil
Copy link

Your app shows for building type = semidetached_house the whole building (2 households) as one object.

This ist not what the wiki and osm.org think it is. They interpret this tag as "half of the semidetached house" or "house attached to another house on one side" (german "Doppelhaushälfte" statt "Doppelhaus").
https://wiki.openstreetmap.org/wiki/Tag:building=semidetached%20house?uselang=de

@westnordost
Copy link
Member

westnordost commented Dec 18, 2020

  1. The app can only be as clear as the wiki and the wiki is not very clear about it, see the discussion page. I bet if you initiated a discussion on it on the forum or mailing list, you'll both find people who argue for Doppelhaus and people who argue for Doppelhaushälfte.
  2. wiki articles in other languages than English should not deviate from the English wiki page but basically be a translation
  3. if the definition has always been that unclear, then this definition becomes the de-facto definition over time. In other words, some semi-detached houses are Doppelhaushälften, some are Doppelhäuser.
  4. In any case, this does not concern StreetComplete that much because the building geometry has already been added. Only the type of building is added by StreetComplete. So if two buildings were "wrongfully" mapped as one, the mistake is already there and StreetComplete (users) don't touch that. On the contrary, by tagging it as semidetached_house, they give the necessary hint what kind of building it is in order to "fix" it (one way or another)

@Nielkrokodil
Copy link

Thank you! I prefer your Doppelhaus-interpretation anyway :)

@westnordost
Copy link
Member

(me too, because the Doppelhaushälfte interpretation would not be that compatible with simple 3d buildings. According to simple 3d buildings, anything that shares a wall and at least things that share a roof should be one building, everything else is building:part. Also, Doppelhaus-interpretation is consistent with building=terrace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet