Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named roads sometimes don't show quests, just dots #1905

Closed
peternewman opened this issue Jun 18, 2020 · 10 comments · Fixed by #1908
Closed

Named roads sometimes don't show quests, just dots #1905

peternewman opened this issue Jun 18, 2020 · 10 comments · Fixed by #1908
Labels

Comments

@peternewman
Copy link
Collaborator

Named roads sometimes don't show quests, just dots

How to Reproduce
Find a short named road with a quest on it (e.g. surface type), zoom in, due to the name changing size, and depending on the length of the road and the length of the name, you may only ever get a dot, or sometimes get a dot and sometimes a quest. It doesn't happen on unnamed ones as there is nothing to clash with.

Sometimes the quest appears and disappears as you zoom in, sometimes it never appears.

Versions affected
v21.0-beta1 Android 9

@matkoniecz
Copy link
Member

Is it happening with some specific location? In general dots should be appearing only on zooming out.

And quests markers should not be blocked by street names - AFAIK there should be no collision at all.

@m-rey
Copy link

m-rey commented Jun 18, 2020

I think I can confirm this. Quest markers interfere with road names. Note that I zoomed in enough, as other quests markers can be seen: screenshot

After rotating the screen (so road name and quest marker don't overlap anymore): screenshot

@matkoniecz
Copy link
Member

Location for testing: https://www.openstreetmap.org/#map=19/49.42402/11.07473

@westnordost
Copy link
Member

Okay, text should of course not block display of the pins

@peternewman
Copy link
Collaborator Author

Okay, text should of course not block display of the pins

However also we'll want to see the street names, unless it's already in the quest text, to ensure we're answering for the right street. So ideally it just wants to resize around the pin if possible.

@matkoniecz
Copy link
Member

I found where order is defined, I am now experimenting to reliably trigger this bug.

@westnordost
Copy link
Member

Actually, text should have a priority, not an order. Not sure how these two interact.

@matkoniecz
Copy link
Member

Looking at https://github.com/tangrams/tangram-docs/blob/610d78b966d603bfdd409580d32e8a793d3d29cd/docs/Syntax-Reference/layers.md#priority it seems that priority is about something else (which styling is applied) - see https://github.com/tangrams/tangram-docs/blob/1f5bf1c6b0568b42aab4ad9cb9c5abfc8e55bc1e/docs/Syntax-Reference/draw.md#order

Though text is supposed to be special, and I am not 100% sure that problem reported here actually happens - text is quite irritating with its disappearing/jumping around, dots make it even more confusing etc

@peternewman
Copy link
Collaborator Author

peternewman commented Jun 20, 2020

Though text is supposed to be special, and I am not 100% sure that problem reported here actually happens - text is quite irritating with its disappearing/jumping around, dots make it even more confusing etc

I assume you're referring to something else (in the documentation perhaps) @matkoniecz? I can provide some more proof of this specific issue if you'd like?

@matkoniecz
Copy link
Member

I debugged it and submitted #1908 - location from #1905 (comment) was very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants