Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What street does the address belong to - not working #1856

Closed
DennisKempel opened this issue May 26, 2020 · 16 comments
Closed

What street does the address belong to - not working #1856

DennisKempel opened this issue May 26, 2020 · 16 comments
Labels

Comments

@DennisKempel
Copy link

Hi, the recently added feature "what Street does ... belong to" and typing on the street to take over its name does not work anymore with the current update. It did work before. Also I noted the quest is English only now whereas it was in German before...

How to Reproduce
Answer the "what Street does ... belong to" quest

Versions affected
Current Android

@westnordost
Copy link
Member

[...] does not work anymore with the current update. It did work before.

This statement is contradictory. The new quest was added in Beta 2, so the current beta version.

You mean to say that tapping on a street does not pre-fill the street input field?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 26, 2020
@westnordost
Copy link
Member

If so, does it work nowhere, or does it not work at a specific location?

@DennisKempel
Copy link
Author

Exactly, and it seems to work nowhere. But as I wrote, it worked the version before...

@DennisKempel
Copy link
Author

...sorry, just trying it on the address Lyserstraße 30, 22761 Hamburg and taking over the name worked now. But it is still in English while I am relatively sure it the quest has been in German when it was first introduced?

@DennisKempel
Copy link
Author

...sorry again, and I'm just noting I am on the beta version, v20.0-beta2

@westnordost
Copy link
Member

The quest has been introduced in v20.0-beta2, it's very new and there is no German translation yet (I think).

@westnordost westnordost removed the bug label May 28, 2020
@westnordost
Copy link
Member

Ok then I will close it. If you can reproduce it in the future, please add the info where you can reproduce it.

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label May 28, 2020
@DennisKempel
Copy link
Author

DennisKempel commented May 29, 2020

@westnordost

Hello, I'm currently Hauptstraße 31, 38543 Hillerse. The quest for this house is still open and tapping on the street does not take over its name...

@westnordost
Copy link
Member

Ok, will have a look!

@westnordost westnordost reopened this May 29, 2020
@westnordost westnordost self-assigned this May 29, 2020
@westnordost
Copy link
Member

Hm, I cannot reproduce it. I can click on "Hauptstraße" and the name is put into the text field.

Does it not work at all, regardless if you tap on Steilbergsweg or Hauptstraße or anywhere for that matter?
Could you try at some other place? Does it not work for you anywhere?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 31, 2020
@westnordost westnordost removed their assignment May 31, 2020
@matkoniecz
Copy link
Member

For me it sometimes work and sometimes not.

It seems that the difference is whatever it is a fresh download or is it created based on solved addr:housenumber quest.

I tried (with just a smartphone, without PC, no log access):

(1) solve addr:housenumber quest.
(2) wait for addr:street
(3) unable to fill by clicking a street
(4)wait for overpass to catch up
(5) flush cache
(6) redownload addr:street
(7) able to fill by clicking a street
(8) revert addr:housenumber solution if it was done with a fake number

@westnordost
Copy link
Member

It seems that the difference is whatever it is a fresh download or is it created based on solved addr:housenumber quest.

Ah, that's it!

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label May 31, 2020
@westnordost
Copy link
Member

I think regrettably there is no better solution than not letting the quest pop up right after the housenumber one was solved. It must download the road names first.

@smichel17
Copy link
Member

How much extra data would it be to just fetch all street names in advance in areas where this quest might be asked?

@westnordost
Copy link
Member

I don't know, but to just always fetch this data would actually be more of an architecture issue. Currently, every quest type is relatively self-contained as in that it can do what it wants on download. So every quest downloads exactly what it needs. Downloading all the street names at the beginning of every download for a bbox is breaking out of this scheme.

@Theodin
Copy link

Theodin commented Jun 2, 2020

Im very happy for your adding this quest as I was about to write a proposal for it today :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants