Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recycling containers are not levitating (location=overground/surface) #1280

Closed
matkoniecz opened this issue Nov 30, 2018 · 8 comments
Closed

Comments

@matkoniecz
Copy link
Member

It may be a good idea to use location=surface rather than location=overground for recycling containers.

location=overground seems to be describing objects that are a bit above ground (say, raised pipelines), not objects on the surface

Disclaimer: location=surface is strongly StreetComplete-inspired tagging. I invented and documented it to allow implementing #1267 - see #907 (comment)

This issues was spotted (and discussed) starting from #377 (comment)

I created a new issue to avoid it getting lost (and because I consider starting new discussions in old PRs/issues as an offtopic, let me know @westnordost if you prefer that over opening new issues).

@westnordost
Copy link
Member

Thank you for creating this as a new issue.

The question is what we do with the places that have been tagged with overground so far.

@matkoniecz
Copy link
Member Author

matkoniecz commented Nov 30, 2018

I see following solutions

  • keep as is (the difference is not massive)
  • run an automated edit (I would get confirmation from DWG that it falls into "fixing my own tagging mistake") what would allow to skip approval process
  • fix manually (horrible waste of time)
  • get approval as for any automated edit but it would mean starting a huge discussion without benefit and decent chance that outcome will be "there is no consensus for an automatic edit" (that is mostly unrelated to whatever automated edit makes sense or not).

I would ask DWG to get confirmation that it falls into "Correcting your own work. If you know that you made a systematic mistake then you may correct this systematically using an automated process. Do however be aware of the risk that your process changes data beyond the scope you intended." in https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct

After that I would run query to get objects that were changed by SC to avoid changing other objects (I have code almost ready for that, assuming that syntax is still the same and metadata is still available on Overpass Turbo after GDPR).

And edit after that should be fairly simple.

@westnordost
Copy link
Member

westnordost commented Nov 30, 2018

Is it possible some easy way to get only elements that were tagged (last) by a certain editor? How can this be achieved? With overpass?

@matkoniecz
Copy link
Member Author

That will miss cases where StreetComplete used edited and later edit was made with other edit but maybe it will be really rare.

But anyway it seems to not be available - there is filter by user ( https://wiki.openstreetmap.org/wiki/Overpass_API/Overpass_QL#By_user_.28user.2C_uid.29 ).

This feature is requested at drolbr/Overpass-API#189

@westnordost
Copy link
Member

So the thing you have available does what?

@westnordost
Copy link
Member

Actually, overground does not mean "(levitating) above the ground" but "On or above the ground." according to most dictionaries. So, the counterpart to underground. Basically a 1:1 translation to German is possible: "überirdisch" which also means exactly that (not underground).
See https://en.oxforddictionaries.com/definition/overground , https://www.thefreedictionary.com/overground, google translate (it's getting better, you know)

Thus, I would say that the tagging for recycling containers is correct and the (new) surface value for location is unnecessary. Or well, perhaps to denote that something is on the ground, like street art painted on roads or the Stolpersteine

@rugk
Copy link
Contributor

rugk commented Dec 5, 2018

or deepl translates it as "oberirdisch". IMHO practically the same as "überirdisch".

@matkoniecz
Copy link
Member Author

Thus, I would say that the tagging for recycling containers is correct and the (new) surface value for location is unnecessary.

In that case I am closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants