Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase MIN_DIST_TO_CYCLEWAYS or exclude bicycle=use_sidepath ways from bikeway quest #1084

Closed
matkoniecz opened this issue May 28, 2018 · 3 comments · Fixed by #1087
Closed

Comments

@matkoniecz
Copy link
Member

matkoniecz commented May 28, 2018

https://www.openstreetmap.org/way/244968825 is over 15m from https://www.openstreetmap.org/way/298887264 so it appears in the bikeway quest despite that it has cycleway tagged along it

present bicycle=use_sidepath hints that there is a separately mapped cycleway, and this tag appears to have some usage (about 60k usages according to https://taginfo.openstreetmap.org//search?q=bicycle%3Duse_sidepath ) so it may be worth supporting

There is also bicycle:forward=use_sidepath and bicycle:backward=use_sidepath with some small usage that may be also added for completeness

@matkoniecz
Copy link
Member Author

matkoniecz commented May 28, 2018

I may make a PR but I want to check what is preferred

  • increasing MIN_DIST_TO_CYCLEWAYS
  • exclude bicycle=use_sidepath
  • exclude bicycle=use_sidepath and bicycle:forward=use_sidepath and bicycle:backward=use_sidepath
  • doing nothing and closing as not worth fixing
  • some combinations of above

@westnordost
Copy link
Member

Mh damn, a sad evidence that geospatial analysis for finding out what un-relationed features belong to each other can never be precise. Your suggestions also only mitigate the underlying issue, but we have to work with what he have.
I think it makes sense to exclude roads with bicycle=use_sidepath and the forward/backward variants (if actually used).
I would also definitely exclude roads tagged with cycleway=sidepath and variants, since this actually more precisely carries exactly the information we are after. Nevermind, it is already excluded, naturally.

@matkoniecz
Copy link
Member Author

and the forward/backward variants (if actually used)

usage is not high, but it should not make code worse (it is one line more, without need for an additional explanation)

and these tags are really used - for example I used them in some cases and from taginfo I see that I am far from being main user of this tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants