Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.1 is unusable and laggy on Nexus 5x #1047

Closed
dbdean opened this issue May 4, 2018 · 12 comments
Closed

Version 5.1 is unusable and laggy on Nexus 5x #1047

dbdean opened this issue May 4, 2018 · 12 comments
Assignees
Labels

Comments

@dbdean
Copy link
Contributor

dbdean commented May 4, 2018

Since the new 5.1 update, the app has been unusable and very slow at doing anything on Nexus 5x. Android keeps coming up and asking me if I wan't to close StreetComplete as it is non responsive.

@westnordost
Copy link
Member

westnordost commented May 4, 2018 via email

@westnordost
Copy link
Member

I can't reproduce it on a Nexus 5 (Lollipop). Which Android version are you using? Perhaps you could look at what the Android Profiler (in Android Studio) shows as the culprit.

@deerwood
Copy link

deerwood commented May 5, 2018

I had the same issue ("StreetComplete reagiert nicht, Schließen oder Warten?") after installing the new 5.1 version. A reboot of my phone solved the problem.

@dbdean
Copy link
Contributor Author

dbdean commented May 5, 2018

Mine has continued being laggy and slow through a reboot, as well as completely wiping the app storage. I don't have Android Studio running at the moment, but I have submitted some reports through the android reporting thing that might contain some details on where it is lagging.

@westnordost
Copy link
Member

Oh yeah, I got quite a few ANR reports.

  #05  pc 0000000000043f74  /data/app/de.westnordost.streetcomplete-QZPCJrGp6mDZfd8FT12p1g==/oat/arm64/base.odex (Java_com_mapzen_tangram_MapController_nativeMarkerSetVisible__JJZ+116)
  at com.mapzen.tangram.MapController.nativeMarkerSetVisible (Native method)
- waiting to lock <0x0edf674d> (a com.mapzen.tangram.MapController) held by thread 15
  at com.mapzen.tangram.MapController.setMarkerVisible (MapController.java:1144)
  at com.mapzen.tangram.Marker.setVisible (Marker.java:185)
  at de.westnordost.streetcomplete.tangram.MapFragment.onRotationChanged (MapFragment.java:478)
  at de.westnordost.streetcomplete.tangram.CompassComponent.onRotationChanged (CompassComponent.java:138)
  at de.westnordost.streetcomplete.tangram.CompassComponent.onSensorChanged (CompassComponent.java:129)
  at android.hardware.SystemSensorManager$SensorEventQueue.dispatchSensorEvent (SystemSensorManager.java:846)

@westnordost westnordost self-assigned this May 5, 2018
@westnordost westnordost added the bug label May 5, 2018
@westnordost
Copy link
Member

(And thread 15 is the GL thread in this case)

Apparently, this occurs only on Android 8 (and perhaps Android 7).

@dbdean
Copy link
Contributor Author

dbdean commented May 6, 2018

I'm Android 8.1, myself. It isn't laggy when I'm moving the map around inside, but gets laggy when I go outside and attempt the same thing, so it might have something to do with GPS.

@padan
Copy link

padan commented May 6, 2018

Experienced this lag too, with StreetComplete 5.1 on Android 5.1 and only with GPS enabled. Downgrading to StreetComplete 5.0 or upgrading to StreetComplete 6.0-beta1 provided by @westnordost works for me. Looking forward to an official update.

@westnordost
Copy link
Member

westnordost commented May 6, 2018

Testing the fix, now on master, would be highly appreciated. (It is yet different from what I sent @padan)

(I do not have an Android 8 device)

@westnordost
Copy link
Member

westnordost added a commit that referenced this issue May 6, 2018
…1047)

- handle orientation sensor callback not on a background thread
- have yet another thread dispatch the rotation to the listener, employing a frame limiter (to 30fps)
- also, correct the calculation for when the display is rotated
@westnordost
Copy link
Member

@padan tested it on his phone, looks good.

@dbdean
Copy link
Contributor Author

dbdean commented May 6, 2018

Looks good for me to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants