-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong position when creating a new note #1039
Comments
Do you know the direction which the map was oriented to when you created the note? This could maybe be the pattern... |
Can you make video of placing note (I use Ez screen recorder for that, it is not ideal but it works) and link such note? It sounds like phone-specific bug or interface misinterpretation. |
This would be quite the critical bug. However, I cannot reproduce it. Placing the note works precisely on portrait and landscape mode, and on any map rotation for my phone. So, I need more information, starting with device and android version, and the things enquired by @matkoniecz |
Also not reproducable with extremely tilted map. I need more information from you, @deerwood |
First 4 tests today: untilted map, fixed to always north, phone in portrait orientation and held almost parallel to ground, phone turned N, S, E and W when positioning marker an pressing OK. All good, position of marker in OSM as set in SC. Will further try to reproduce with tilted map. Besides, my phone is a cheap Wiko Pulp 3G with Android 5.1, in case that matters. |
The Android version seems not to matter then, I cannot reproduce it with an Android 5.1. Perhaps you could also try to open the note dialog in portrait, then rotating the phone and then posting the note. Otherwise, I have no further ideas. |
Perhaps this came together like this?: http://www.westnordost.de/misc/screenrotate_shifts_note.mp4 You first placed the note, then rotated the screen to have a larger input field and on finishing it you did not notice that the note shifted on screen rotate (because the keyboard covered it) |
…oard closed (#1039) On composing a note, first close the keyboard on click on OK. Only when keyboard is closed will a click on OK lead to the note being saved. This enables to user to always see the exact position of the note before he saves it, as the note position (necessarily) shifts when rotating the phone.
I implemented now that a press on "OK" first closes the keyboard if it is still open, then another click on "OK" will save the note. |
I suggest changing the word "Ok" to "Save" when the keyboard is collapsed. |
Er, collapsed and the field isn't zero-length. |
Closing the keyboard and thus showing the marker again is a good idea. However I'm pretty sure to have closed the keyboard manually always. And I never use landscape mode (only accidently). Usually the phone is on my bikes handlebar in portrait mode ~30° tilt, when entering longer text, I remove it and hold it ~45° tilt. I most often have the map tilted and manually turned into driving direction, even when entering new notes. The wrongly placed notes where added after having used SC for 2-4 hours with screen always on and thus battery rather low. I'll further investigate the next days. Maybe it is a problem with my phone? |
I can't imagine how it would be a problem with your phone. |
…oard closed (#1039) On composing a note, first close the keyboard on click on OK. Only when keyboard is closed will a click on OK lead to the note being saved. This enables to user to always see the exact position of the note before he saves it, as the note position (necessarily) shifts when rotating the phone.
I tested again several times, now with tilted and rotated map and after ~1-3 hours usage of SC. No problem at all aka I can't reproduce. So I'm sorry to have bothered you with a false alarm. |
When creating a new free note (with button bottom left) I always make sure to set the mark at the very exact position, even zooming in as far as possible.
But the marks don't show up in OpenStreetMap at the correct location. They have some offset, annoying other OSM editors.
See examples:
Note north of POI
Note south of POI:
The offset in the samples is ~10-20 meters. I couldn't find a systematic/pattern for the direction.
The text was updated successfully, but these errors were encountered: