Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include relations in search for parking areas #1033

Closed
BjornRasmussen opened this issue Apr 26, 2018 · 3 comments
Closed

Include relations in search for parking areas #1033

BjornRasmussen opened this issue Apr 26, 2018 · 3 comments

Comments

@BjornRasmussen
Copy link

After using StreetComplete, I have noticed that it does not edit Multipolygons. In my town, many parking lots are added as multipolygons due to the presence of buildings in the center of them. As far as I can tell, missing tagging in these parking lots is not noticed by StreetComplete.

@ENT8R
Copy link
Contributor

ENT8R commented Apr 26, 2018

This is because the query does not search for them. The current query for the parking type looks like this:
https://github.com/westnordost/StreetComplete/blob/00072402b52431e78e51df0165153dffa556f24d/app/src/main/java/de/westnordost/streetcomplete/quests/parking_type/AddParkingType.java#L24

Which means that it searches only for points and normal areas with the tag amenity=parking and without the tag parking=*. I'm not sure what the wiki article says about mapping parkings as realtions (multipolygons) as it says: "use on relations unspecified". But IMO they can be included and one just needs to add a single word to the query: nodes, ways, relations with amenity=parking and !parking
But it also does not make sense to add this to every quest.
Is there some reason that we didn't include relations or did we just forgot it? 😄

@matkoniecz
Copy link
Member

as it says: "use on relations unspecified"

It has "may be used on areas" (what includes multipolygons) at https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dparkingm .

and anyway, amenity=parking is widely used on multipolygons so if wiki claimed otherwise it should be changed

@westnordost westnordost changed the title Multipolygons Include relations in search for parking areas Apr 26, 2018
@westnordost
Copy link
Member

Should also be checked for the other (parking) quests if also looking for releations (=multipolygons) makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants