Quest: What is the primary cuisine of this amenity=restaurant|cafe|fast_food #103
Comments
|
Prerequisite: A tag dictionary that has all those (common) cuisine values for all languages. |
westnordost
added
the
new quest
|
Ideally, don't let people tag it as vegan/vegetarian. There is a specific key for that: https://wiki.openstreetmap.org/wiki/Key:diet |
|
@picsi Maybe make a new quest/issue about this? |
|
But the Four ways to get all cuisine type's names in different languages:
|
https://poeditor.com/ is already used (see Readme) and the translators there usually translate strings very fast. |
|
Let's get back at this quest, as said for restaurants it is a very important one. Of course, only solvable from the inside, so should be disabled by default. BTW if one needs a use case of the data: Maps/Maps.me uses (displays) it and also allows adding it. As for the data, is not that easy? Just use the OSM wiki, or taginfo to get all available data, @westnordost? The rest would be like a street name quest with a simple dropdown/autocomplete. ... or make a picture quest with fixed values. This may even be better, as it is more illustrative. (One could even use the entries Maps.me offers there.) |
|
Another way to solve the problem that the user is overwhelmed by the options would be a search box (as in MAPS.ME). |
|
A search box would basically just be, what i said earlier:
I.e. not a picture quest, but the street name quest, in a different way. |
|
A least vespucci allows multiple values as |
|
Sure, that would be possible with a picture quest, too. |
|
Should be unblocked now since https://github.com/westnordost/osmfeatures is implemented. |
|
From #1938: Question asked: Which cuisine does XY offer? Element selection:
Originally posted by @matkoniecz in #1938 (comment):
|
|
Maybe we should split this up into two separate quests, one for the type of food, and one for the ethnicity? For ethnicity, we could use a UI similar to the I've tried to categorize the ethnicity
|
That would require a new tagging scheme that should be probably discussed elsewhere (or put both into a single cuisine tag?) |
|
I thought both could be added to a single |
|
Actually, I wouldn't want to invent anything myself here but just use the iD presets. All this stuff you suggested would need to be translated as well. For the iD presets, it already is. |
|
It's not that much though: https://github.com/openstreetmap/iD/tree/develop/data/presets/presets/amenity/restaurant |
|
Then the question is whatever it is good enough to cover most of cases. Maybe also some other values deserve to appear in iD? (iD issues/PRs should be opened solely on basis whatever iD needs that, not potential SC use) |
|
Blocked because we need translations for all the different possible/popular cuisines, maybe from iD when/if they start also translating keys/values. It is not a good idea to start translating all the possible tag values for cuisines in StreetComplete (too many). |
|
Status of potential iD feature is at openstreetmap/iD#2708 (I just upvoted that issue) In general it is a poor idea to ping maintainers and ask them whatever feature X is getting implemented (usually if there is no activity in a relevant issue the answer is "no"). BTW, https://github.com/openstreetmap/iD#participate has "Come on in, the water's lovely. More help? Ping bhousel or quincylvania on:(...)" with some channels listed (though it is for people interested in contributing, not just ones asking that someone else will implement something). |
|
Hi friends, an update on the iD strings. I'm planning to close openstreetmap/iD#2708 for the next iD release. The PR is openstreetmap/iD#8238. As far as what this means for StreetComplete: we'll be adding a lot more translatable tag labels to the field data over at the id-tagging-schema. Feel free to head over and open issues/PRs for whatever you need. |
|
I'd love to see this so I took some time to translate all the tags from the wiki page to Italian, I also added a "popularity" column based on my knowledge/experience to add a weight to these items (to show them first in a list of available options if needed) CLICK HERE TO SHOW
Ethnicity:
I also tried to make a table of foods to show first in a list of available options depending on the ethnicity of the cuisine. All my info come from Wikipedia articles which I read, so they could not be exact, any correction is welcome! UPDATE: it looks like iD already does that, I leave it here if anyone needs this SHOW
|
|
@naposm I am not sure on the details where the names for preset field values in iD will be sourced from but I can tell you that here is definitely the wrong location. @quincylvania Will it be in transifex or some wikidata items? Maybe you can give @naposm a pointer where he can contribute that information to. |
|
Also, will the field values have a possible icon in iD? For cuisines, this might be quite nice! Heck, maybe even just icons and no names?! |
|
@westnordost Yeah, I knew that maybe it was not the best place, I just wanted to make a model to do the same in other languages. I sure can transfer them to iD if possible. I'll take a look. 😁 |
That part of your work (popularity) is I think in vain. The iD editor already sorts suggested values for preset fields by usage count according to taginfo. What it does not do however, I think, is to sort them by usage count per country/region which in this case would make sense I guess. You could file a feature request at the id editor github for this. |
Great! Had no clue iD did that. I mean, if it's already there then better not reinvent the wheel, I agree 100%. I don't know if they would implement it as it is not very useful and depends if ethnicity has not been set but I might try asking if StreetComplete will implement this feature using data from iD as my idea is mainly aimed at mobile users so they don't have to scroll a long list of items as they would answer this quest while waiting for lunch most of the time. |
|
Prerequisite for that would be to have
While iD presets right now are in limbo, the first issue is still unsolved and requires no coding whatsoever, "only" consulting with other mappers to ensure that values are covering most of what exists. So following would be needed: Review tagging Maybe with organic growth it already covers this? But mappers should be asked whether there are some common cuisines without appropriate tagging for that. Yes, resolving that would take massive effort. Provide guidelines It would be also nice to have some decision what should be used: Translations I would gladly help with this step (though no promises that I will have time in say 2025). And after that it would necessary to select some subset of 1762 (current state) values, setup translation project for them etc. Or include far more cuisines in iD presets. Quest And at this stage quest can be implemented. I would gladly help with this step (though no promises that I will have time in say 2025). Overall it seems to me that there is a significant, non-programming work to do before this can be implemented, so I will close this issue for now. Not because it is a bad idea, but because significant improvements needs to be done with tagging schema before it will be safe to implement something. Once tagging schema is in better stage - please write here and it will be reopened. If someone works on improving this - linking some external discussions is also likely a good idea. |
|
You could also mark this as blocked, but closed is also fine, after all it can be opened again no problem. |
|
It is marked as blocked since 2020-09-06. I would prefer to close such issues as it is annoying when looking through issue tracker. And seems likely that it will be stuck in such state for years or longer. Maybe some additional label like "reopenable" / "restartable" would be nice? I would expect open issue with "blocked" to be applied to things that can become actionable within months and there is any progress happening or decent chance for that. |
|
You are right. Often, it also makes more sense to re-start (i.e. open a new) an issue rather than reopening an old one which already has 100 messages in it. |
Let’s discuss this idea further on the wiki talk page. It’s a good idea, but it would have impacts far beyond StreetComplete.
Can you elaborate on why this would be a prerequisite? Is it because the repertoire of documented values is currently skewed in favor of certain cultures over others? Or because StreetComplete needs to distinguish a currently inexpressible cuisine from a restaurant that has no discernible cuisine?
The iD tagging schema already makes some common |
Because otherwise this would need to be done while implementing quest or after implementing quest. Otherwise StreetComplete users would be leaving large amount of notes due to missing ability to answer correctly and be more likely to give invalid answers.
It is possible that it could be - or it has some other issues that right now are ignored and SC quest would reveal.
ooo, that is one more problem: are there places with no specific cuisine? How to mark them? Otherwise SC would ask about them endlessly.
|
Personally, I routinely omit |
|
If such tagging is preferred/recommended then it would make this quest impossible as SC would have no way to distinguish "no tagged cuisine" and "no specific cuisine". |
add some popular cuisines that appear to be valid this will allow translating this values triggered by streetcomplete/StreetComplete#103 (comment) based on https://taginfo.openstreetmap.org/keys/cuisine#values Co-authored-by: Peter Newman <[email protected]>
|
openstreetmap/id-tagging-schema#252 got merged, the next step would be to review top values and see what is sill missing in https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/cuisine.json You can either make own pull request to iD presets or just list missing cuisines with their English names and open an issue at https://github.com/openstreetmap/id-tagging-schema/issues and ping me by using @matkoniecz in text I plan on doing it, but it can take me months - and it is quite time consuming but relatively simple to |
Answers:
Used by:
The text was updated successfully, but these errors were encountered: