Skip to content

Commit

Permalink
remove duplicated test
Browse files Browse the repository at this point in the history
  • Loading branch information
matkoniecz committed Oct 14, 2021
1 parent 92b4d1d commit d259ed0
Showing 1 changed file with 1 addition and 13 deletions.
Original file line number Diff line number Diff line change
@@ -49,19 +49,6 @@ class AddStileTypeTest {
StringMapEntryModify("material", "wood", "stone"),
)
}
@Test
fun `don't reset tags when adding a stile type tag to an existing enhanced metadata stile`() {
questType.verifyAnswer(
mapOf(
"barrier" to "stile",
"material" to "stone",
"tag_not_in_list_for_removal" to "dummy_value",
),
BarrierType.STILE_SQUEEZER,
StringMapEntryAdd("stile", "squeezer"),
StringMapEntryAdd("material", "stone"),
)
}

@Test
fun `don't reset tags when adding a stile type tag to an existing enhanced metadata stile`() {
@@ -76,6 +63,7 @@ class AddStileTypeTest {
StringMapEntryAdd("material", "stone"),
)
}

@Test
fun `handle unmodified, fully tagged stepover`() {
questType.verifyAnswer(

4 comments on commit d259ed0

@peternewman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not duplicated, they're two different paths through two different bits of your code! We don't tag a material on squeezer, but a user may have done so; we do on stepover.

@smichel17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the test should be renamed, then.

@peternewman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realise they needed unique function names/hadn't spotted they were the same.

@smichel17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if they need to be unique, but at least for human-readability…

Please sign in to comment.