Merge branch 'master' of https://github.com/westnordost/StreetComplete

streetcomplete · May 31, 2020 · cc27045 · cc27045
2 parents 9748840 + f9f2b3b
commit cc27045
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/osmquest/OsmQuestDownloader.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/osmquest/OsmQuestDownloader.kt
@@ -86,21 +86,21 @@ class OsmQuestDownloader @Inject constructor(
         if (geometry is ElementPolylinesGeometry) {
             val totalLength = geometry.polylines.sumByDouble { it.measuredLength() }
             if (totalLength > MAX_GEOMETRY_LENGTH_IN_METERS) {
-                Log.d(TAG, "$questTypeName: Not adding a quest at ${pos.toLogString()} because the geometry is too long")
+                Log.d(TAG, "$questTypeName: Not adding a quest for ${element.toLogString()} at ${pos.toLogString()} because the geometry is too long")
                 return false
             }
         }
 
         // do not create quests whose marker is at/near a blacklisted position
         if (blacklistedPositions.contains(pos.truncateTo5Decimals())) {
-            Log.d(TAG, "$questTypeName: Not adding a quest at ${pos.toLogString()} because there is a note at that position")
+            Log.d(TAG, "$questTypeName: Not adding a quest for ${element.toLogString()} at ${pos.toLogString()} because there is a note at that position")
             return false
         }
 
         // do not create quests in countries where the quest is not activated
         val countries = questType.enabledInCountries
         if (!countryBoundaries.isInAny(pos, countries)) {
-            Log.d(TAG, "$questTypeName: Not adding a quest at ${pos.toLogString()} because the quest is disabled in this country")
+            Log.d(TAG, "$questTypeName: Not adding a quest for ${element.toLogString()} at ${pos.toLogString()} because the quest is disabled in this country")
             return false
         }
 

diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/crossing_type/AddCrossingType.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/crossing_type/AddCrossingType.kt
@@ -7,7 +7,7 @@ import de.westnordost.streetcomplete.data.osm.mapdata.OverpassMapDataAndGeometry
 
 class AddCrossingType(o: OverpassMapDataAndGeometryApi) : SimpleOverpassQuestType<String>(o) {
 
-    override val tagFilters = "nodes with highway = crossing and (!crossing or crossing = island)"
+    override val tagFilters = "nodes with highway = crossing and (!crossing or crossing = island) and foot!=no"
     override val commitMessage = "Add crossing type"
     override val wikiLink = "Key:crossing"
     override val icon = R.drawable.ic_quest_pedestrian_crossing