Skip to content

Commit

Permalink
reduce the size of downloaded areas so that quests are closer to the …
Browse files Browse the repository at this point in the history
…user (fixes #1357)
  • Loading branch information
westnordost committed May 23, 2019
1 parent b39fb59 commit 3a8c73a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ public class ApplicationConstants
public final static Date DATE_OF_BIRTH = new GregorianCalendar(2017,Calendar.FEBRUARY,20).getTime();

public final static double
MAX_DOWNLOADABLE_AREA_IN_SQKM = 50,
MIN_DOWNLOADABLE_AREA_IN_SQKM = 4;
MAX_DOWNLOADABLE_AREA_IN_SQKM = 20,
MIN_DOWNLOADABLE_AREA_IN_SQKM = 1;

public final static double MIN_DOWNLOADABLE_RADIUS_IN_METERS = 1000;
public final static double MIN_DOWNLOADABLE_RADIUS_IN_METERS = 600;

public final static String DATABASE_NAME = "streetcomplete.db";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ public class MobileDataAutoDownloadStrategy extends AActiveRadiusStrategy

@Override protected int[] getActiveRadii()
{
return new int[]{400};
return new int[]{300};
}

@Override protected int getDownloadRadius()
{
return 800;
return 600;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ public class WifiAutoDownloadStrategy extends AActiveRadiusStrategy

@Override protected int[] getActiveRadii()
{
// checks if either in 1200 or 400m radius, there are enough quests.
return new int[]{1200, 400};
// checks if either in 600 or 300m radius, there are enough quests.
return new int[]{600, 300};
}

@Override protected int getDownloadRadius()
{
return 2400;
return 1200;
}
}

4 comments on commit 3a8c73a

@Atrate
Copy link
Contributor

@Atrate Atrate commented on 3a8c73a May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making an option for the user to choose the size of downloaded areas? I would like to download big areas at once, because I commute a lot and I would't have to have my data on at all times

@westnordost
Copy link
Member Author

@westnordost westnordost commented on 3a8c73a May 25, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuiqzy
Copy link
Contributor

@xuiqzy xuiqzy commented on 3a8c73a Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale for also reducing the MAX_DOWNLOADABLE_AREA_IN_SQKM ?

@westnordost
Copy link
Member Author

@westnordost westnordost commented on 3a8c73a Jun 30, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.