Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
because 1. the tag is documented as nodes only 2. there aren't many ways with the tag 3. the charging station operator quest also does it
- Loading branch information
1 parent
267ee3b
commit 0cb8b43
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere (in the wiki?) I saw a picture of a charging station that was larger, i.e. looked like a petrol station, probably this is why I included ways.
Also, question is, should the charging station considered to be just the pillar with the sockets or the pillar + the space where the cars should park while being loaded.
Since obviously, the mentioned space is blocked for anything else (f.e. can not be used as a parking space), it would make sense if it was the latter. And since we already started to micromap parking lots that consist of just a few (or less) parking spaces, and since we map bicycle and motorcycle parking also as areas, I think it cannot be considered wrong to map these charging stations as areas.
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, looking at duckduckgo image search, it does look like multi-pillar car charging stations are all but uncommon:
https://duckduckgo.com/?t=ffab&q=car+charging+station&iax=images&ia=images&iai=https%3A%2F%2Felectrek.co%2Fwp-content%2Fuploads%2Fsites%2F3%2F2017%2F12%2Fultra-e.jpg%3Fquality%3D82%26strip%3Dall
Such places are big enough to warrant area-mapping even for non-micromapping fans.
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with including ways, but then it should be consistent in both the capacity and the operator quests.
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's do that then
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, 318 ways vs 52k nodes is maybe not worth searching for: https://taginfo.openstreetmap.org/tags/amenity=charging_station#overview
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean, not worth searching for? We are downloading everything anyway, we are not using overpass anymore
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
98661de
I also added a talk topic in the wiki regarding this https://wiki.openstreetmap.org/wiki/Talk:Tag:amenity%3Dcharging_station#on_areas.3F and am subscribed to the wiki page in case there are answers.
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, filtering takes a little less time if it's fewer items to search through. That's probably negligible though.
0cb8b43There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd also say it is negligible. What may make a little difference would be (a utility function) that makes filtering the
mapData(mapData.ways.filter { filter.matches(it) }) not iterate through the whole mapData if thefilterf.e. only includesways, relations. I.e. put the performance improvement that can be seen inOsmFilterQuestTypeinto an (extension) function forMapData.