Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added field level support for @Deprecated annotation #169

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Added field level support for @Deprecated annotation #169

merged 5 commits into from
Oct 29, 2021

Conversation

rahulreddym
Copy link
Contributor

@rahulreddym rahulreddym commented Oct 26, 2021 •
edited
Loading

  • Regenerated the well-know types for the CI tests to pass.
  • The @deprecated annotation now includes empty message argument.

@rahulreddym rahulreddym requested a review from garyp October 26, 2021 22:37
@garyp
Copy link
Collaborator

garyp commented Oct 27, 2021

Looks like the CI test failed because your PR causes changes to the generated code that is bundled within pbandk. See https://github.com/streem/pbandk#bundled-types for instructions on how to re-generate that code. Add those changes to this PR and CI should pass.

@garyp
Copy link
Collaborator

garyp commented Oct 27, 2021

We should handle fields that are inside of a oneof (this would be in the CodeGenerator.writeOneOfType() method) and inside of an extension (in the CodeGenerator.writeExtension() method). Those are probably simple changes as well. But we can also get this PR merged without that, in which case please add these cases to the todo list in #1 so we can keep track of the work remaining.

@garyp garyp added this to the 0.12.0 milestone Oct 27, 2021
@garyp garyp merged commit 3a3b7a5 into master Oct 29, 2021
@garyp garyp deleted the feature/add-deprecated-annotation-for-kotlin branch October 29, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyp garyp garyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulreddym @garyp