Update job jar location #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jar was moved in the runner image Signed-off-by: Robert Young <[email protected]>
Flink was complaining it was deprecated, it looks like the property naming changed in flink 1.14 Signed-off-by: Robert Young <[email protected]>
|
Could you explain more about this?
The change doesn't have any problem. Just be interested in the change motivation. Thanks. |
|
When running the job prior to the change you see this in the logs multiple times:
|
showuon
approved these changes
Sep 6, 2024
kornys
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamshub/flink-sql#20 changed the job jar location to
/opt/streamshub/The job was also complaining about deprecated
value.avro-confluent.schema-registry.urlso I went and changed it.