Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker: remove eslint exceptions #245

Merged
merged 9 commits into from
Oct 13, 2021
Merged

Broker: remove eslint exceptions #245

merged 9 commits into from
Oct 13, 2021

Conversation

harbu
Copy link
Contributor

@harbu harbu commented Oct 12, 2021 •
edited
Loading

Remove exceptions from packages/broker/.eslintrc and make the code adhere to base eslint rules.

@harbu harbu requested a review from teogeb October 12, 2021 16:05
@github-actions github-actions bot added the broker Related to Broker Package label Oct 12, 2021
@harbu harbu changed the title Broker fix eslint rules (wip) Broker: remove eslint exceptions Oct 12, 2021
teogeb
teogeb approved these changes Oct 12, 2021
View reviewed changes
packages/broker/src/plugins/storage/DeleteExpiredCmd.ts Outdated
}

await this.cassandraClient.shutdown()
}

async _getStreams(): Promise<StreamPart[]> {
async getStreams(): Promise<StreamPart[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could mark getStreams, fetchStreamsInfo, getPotentiallyExpiredBuckets, filterExpiredBuckets and deleteExpired as private

@harbu harbu merged commit 34fe885 into main Oct 13, 2021
@harbu harbu deleted the broker-fix-eslint-rules branch October 13, 2021 11:42
timoxley added a commit that referenced this pull request Oct 13, 2021
@timoxley
Merge branch 'main' into NET-542-brubeck-client-browser
52f7716 
* main:
  Broker: remove eslint exceptions (#245)
  test(client): fix validation test
  protocol: function return types (#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teogeb teogeb teogeb approved these changes

Assignees
No one assigned
Labels
broker Related to Broker Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harbu @teogeb