-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add backlog quota command for topic #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
backlog_quota_topic
branch
5 times, most recently
from
August 23, 2021 08:11
699a5d6
to
d512454
Compare
nodece
force-pushed
the
backlog_quota_topic
branch
2 times, most recently
from
August 24, 2021 08:36
ea9fbe2
to
269ba87
Compare
61 tasks
zymap
reviewed
Aug 30, 2021
zymap
reviewed
Aug 30, 2021
Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
backlog_quota_topic
branch
from
August 30, 2021 02:30
269ba87
to
f58df5d
Compare
zymap
approved these changes
Sep 1, 2021
nodece
added a commit
that referenced
this pull request
Nov 12, 2021
Signed-off-by: Zixuan Liu <[email protected]> ### Changes background from #246, the PR implements the following commands: - `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic - `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic - `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic ### TODO - [x] Add integration tests (cherry picked from commit c58eef0)
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Zixuan Liu <[email protected]> ### Changes background from streamnative/pulsarctl#246, the PR implements the following commands: - `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic - `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic - `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic ### TODO - [x] Add integration tests
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Zixuan Liu <[email protected]> ### Changes background from streamnative/pulsarctl#246, the PR implements the following commands: - `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic - `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic - `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic ### TODO - [x] Add integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu [email protected]
Changes
background from #246, the PR implements the following commands:
pulsarctl topics get-backlog-quotas <topic> -a
- Get the backlog quota policy for a topicpulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>
- Remove a backlog quota policy from a topicpulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>
- Set a backlog quota policy for a topicTODO