Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backlog quota command for topic #429

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

nodece
Copy link
Contributor

@nodece nodece commented Aug 20, 2021

Signed-off-by: Zixuan Liu [email protected]

Changes

background from #246, the PR implements the following commands:

  • pulsarctl topics get-backlog-quotas <topic> -a - Get the backlog quota policy for a topic
  • pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age> - Remove a backlog quota policy from a topic
  • pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age> - Set a backlog quota policy for a topic

TODO

  • Add integration tests

@nodece nodece requested review from zymap and a team as code owners August 20, 2021 10:31
@nodece nodece marked this pull request as draft August 20, 2021 10:31
@nodece nodece force-pushed the backlog_quota_topic branch 5 times, most recently from 699a5d6 to d512454 Compare August 23, 2021 08:11
@nodece nodece marked this pull request as ready for review August 23, 2021 08:18
@nodece nodece force-pushed the backlog_quota_topic branch 2 times, most recently from ea9fbe2 to 269ba87 Compare August 24, 2021 08:36
@nodece nodece force-pushed the backlog_quota_topic branch from 269ba87 to f58df5d Compare August 30, 2021 02:30
@nodece nodece requested a review from zymap August 30, 2021 02:32
@zymap zymap merged commit c58eef0 into streamnative:master Sep 1, 2021
nodece added a commit that referenced this pull request Nov 12, 2021
Signed-off-by: Zixuan Liu <[email protected]>

### Changes

background from #246,  the PR implements the following commands:

- `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic
- `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic
- `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic

### TODO
- [x] Add integration tests

(cherry picked from commit c58eef0)
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
Signed-off-by: Zixuan Liu <[email protected]>

### Changes

background from streamnative/pulsarctl#246,  the PR implements the following commands:

- `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic
- `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic
- `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic

### TODO
- [x] Add integration tests
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
Signed-off-by: Zixuan Liu <[email protected]>

### Changes

background from streamnative/pulsarctl#246,  the PR implements the following commands:

- `pulsarctl topics get-backlog-quotas <topic> -a` - Get the backlog quota policy for a topic
- `pulsarctl topics remove-backlog-quota <topic> --type <producer_request_hold|message_age>` - Remove a backlog quota policy from a topic
- `pulsarctl topics set-backlog-quota <topic> --limit-size <string> --limit-time <int> --policy <producer_request_hold|producer_exception|consumer_backlog_eviction> --type <producer_request_hold|message_age>` - Set a backlog quota policy for a topic

### TODO
- [x] Add integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants