This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[fix][transaction] Contains UUID when auto topic creation #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
============================================
- Coverage 17.07% 17.03% -0.05%
+ Complexity 728 727 -1
============================================
Files 191 191
Lines 14218 14235 +17
Branches 1329 1332 +3
============================================
- Hits 2428 2425 -3
- Misses 11614 11633 +19
- Partials 176 177 +1
|
gaoran10
approved these changes
Aug 8, 2023
BewareMyPower
approved these changes
Aug 9, 2023
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Oct 30, 2023
…ve#1993) ### Motivation In PR streamnative#1943 , it introduced using UUID to distinguish deleted/created topics, but when the topic is auto-created, the UUID is not contained in the properties. ### Modifications Contains UUID when auto topic creation (cherry picked from commit 26980a3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #1943 , it introduced using UUID to distinguish deleted/created topics, but when the topic is auto-created, the UUID is not contained in the properties.
Modifications
Contains UUID when auto topic creation
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)