Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix botocore/python-dateutil dependency #787

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

tconkling
Copy link
Contributor

Pins python-dateutil to a version <= 2.8.0. python-dateutil's latest version is 2.8.1, but our botocore dependency is incompatible with that version (see boto/botocore#1872 for more details).

We can remove this once the botocore dependency has been fixed.

  • I also added a lib/Pipfile.locks/README.md, to help avoid future confusion about the purpose of that directory
  • And I removed lib/Pipfile.locks/python-3.7.3, because we're no longer testing against that version of Python in CircleCI.

Fixes #644

@tconkling tconkling requested a review from a team as a code owner December 3, 2019 23:50
@tconkling tconkling requested a review from nthmost December 3, 2019 23:51
@tconkling tconkling merged commit 1f89e36 into streamlit:develop Dec 4, 2019
@tconkling tconkling deleted the tim/FixBotocoreDependency branch December 4, 2019 20:50
@ecederstrand
Copy link
Contributor

botocore was fixed upstream in boto/botocore@95a6f8e so the python-dateutil restriction can be lifted again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in Uber demo
3 participants