Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onChange callback to useWindowSize (#915) #2608

Merged
merged 2 commits into from
Dec 9, 2024
Merged

feat: add onChange callback to useWindowSize (#915) #2608

merged 2 commits into from
Dec 9, 2024

Conversation

mahmoud-elgammal
Copy link
Contributor

Description

This update adds an onChange callback to the useWindowSize hook, allowing custom logic to be executed on window resize. It also integrates @storybook/addon-actions to log resize events in Storybook's "Actions" panel.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@mahmoud-elgammal mahmoud-elgammal mentioned this pull request Dec 2, 2024
Open
streamich
streamich approved these changes Dec 9, 2024
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@streamich streamich merged commit 7602956 into streamich:master Dec 9, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 17.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahmoud-elgammal @streamich